1086252 - Show stable client id in about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Add client id to about:telemetry

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8509537 [details] [diff] [review]
Add client id to about:telemetry

Review of attachment 8509537 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutTelemetry.js
@@ +111,5 @@
> +let GeneralData = {
> +  /**
> +   * Renders the general data
> +   */
> +  render: function ChromeHangs_render() {

Either call this GeneralData_render, or just let the smart-naming in the JS engine handle it.

@@ +135,5 @@
> +    dataDiv.appendChild(table);
> +  },
> +
> +  /**
> +   * Helper function for appending a column to a Slow SQL table.

Probably need to update the docstring here.

@@ +141,5 @@
> +   * @param aRowElement Parent row element
> +   * @param aColType Column's tag name
> +   * @param aColText Column contents
> +   */
> +  appendColumn: function SlowSQL_appendColumn(aRowElement, aColType, aColText) {

Likewise on the function name.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Oh, thanks for catching the naming issues.

Comment 4

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/710ca80bb1d7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/710ca80bb1d7

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8509537 [details] [diff] [review]
Add client id to about:telemetry

Approval Request Comment
[Feature/regressing bug #]: Search telemetry. This is a dependency for bug 1064333.
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]:
See bug 1064333, comment 55.
[String/UUID change made/needed]: None.

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> [String/UUID change made/needed]: None.

Not actually true - this has about:telemetry string changes, which untranslated should be acceptable.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

I don't think that we translate about:telemetry but want to ni flod to confirm and grant l10n approval for the landing.

Comment 9

[Francesco Lodolo [:flod]]

Same answer that I gave in https://bugzilla.mozilla.org/show_bug.cgi?id=1092176#c8

1) about:telemetry is localized

2) if you really need this on Aurora/Beta, please create a string-free patch (put the string in the code, don't modify .dtd/.properties). The string won't be localizable for 2 cycles, but at least this won't create unnecessary noise on string frozen branches.

Comment 10

[Georg Fritzsche [:gfritzsche]]

Attachment: Aurora/Beta patch: Add client id to about:telemetry

Approval Request Comment:
See comment 6. This version just addresses the above l10n concerns by making the strings untranslatable.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8515600 [details] [diff] [review]
Aurora/Beta patch: Add client id to about:telemetry

Thanks you for addressing the l10n concerns. Beta+ Aurora+

Comment 12

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7627d347ead

Comment 13

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bda711062d08