Show stable client id in about:telemetry

RESOLVED FIXED in Firefox 34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

unspecified
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox33 unaffected, firefox34 fixed, firefox35 fixed, firefox36 fixed)

Details

Attachments

(2 attachments)

No description provided.
Comment on attachment 8509537 [details] [diff] [review]
Add client id to about:telemetry

Review of attachment 8509537 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutTelemetry.js
@@ +111,5 @@
> +let GeneralData = {
> +  /**
> +   * Renders the general data
> +   */
> +  render: function ChromeHangs_render() {

Either call this GeneralData_render, or just let the smart-naming in the JS engine handle it.

@@ +135,5 @@
> +    dataDiv.appendChild(table);
> +  },
> +
> +  /**
> +   * Helper function for appending a column to a Slow SQL table.

Probably need to update the docstring here.

@@ +141,5 @@
> +   * @param aRowElement Parent row element
> +   * @param aColType Column's tag name
> +   * @param aColText Column contents
> +   */
> +  appendColumn: function SlowSQL_appendColumn(aRowElement, aColType, aColText) {

Likewise on the function name.
Attachment #8509537 - Flags: review?(nfroyd) → review+
Oh, thanks for catching the naming issues.
https://hg.mozilla.org/mozilla-central/rev/710ca80bb1d7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8509537 [details] [diff] [review]
Add client id to about:telemetry

Approval Request Comment
[Feature/regressing bug #]: Search telemetry. This is a dependency for bug 1064333.
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]:
See bug 1064333, comment 55.
[String/UUID change made/needed]: None.
Attachment #8509537 - Flags: approval-mozilla-beta?
Attachment #8509537 - Flags: approval-mozilla-aurora?
(In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> [String/UUID change made/needed]: None.

Not actually true - this has about:telemetry string changes, which untranslated should be acceptable.
I don't think that we translate about:telemetry but want to ni flod to confirm and grant l10n approval for the landing.
Flags: needinfo?(francesco.lodolo)
Same answer that I gave in https://bugzilla.mozilla.org/show_bug.cgi?id=1092176#c8

1) about:telemetry is localized

2) if you really need this on Aurora/Beta, please create a string-free patch (put the string in the code, don't modify .dtd/.properties). The string won't be localizable for 2 cycles, but at least this won't create unnecessary noise on string frozen branches.
Flags: needinfo?(francesco.lodolo)
Approval Request Comment:
See comment 6. This version just addresses the above l10n concerns by making the strings untranslatable.
Attachment #8515600 - Flags: approval-mozilla-beta?
Attachment #8515600 - Flags: approval-mozilla-aurora?
Attachment #8509537 - Flags: approval-mozilla-beta?
Attachment #8509537 - Flags: approval-mozilla-aurora?
Comment on attachment 8515600 [details] [diff] [review]
Aurora/Beta patch: Add client id to about:telemetry

Thanks you for addressing the l10n concerns. Beta+ Aurora+
Attachment #8515600 - Flags: approval-mozilla-beta?
Attachment #8515600 - Flags: approval-mozilla-beta+
Attachment #8515600 - Flags: approval-mozilla-aurora?
Attachment #8515600 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.