1086277 - Add a test for add & delete a divider on homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

Implement test case to add and delete homescreen divider.
This will be done by moving an icon from the top to the bottom of the homescreen, then move it back up.

https://moztrap.mozilla.org/manage/case/13082/
https://moztrap.mozilla.org/manage/case/13096/

Comment 1

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

This is a good start. I tested it and the test is working. I think we should refactor some things. I left comments in Github.

Comment 3

[Florin Strugariu [:Bebe]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

the pull looks like a good start
I will wait for the current issues to be fixed before I submit my final review

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

I updated the PR according to some of the comments left there.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

LGTM!

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

Comments in the PR

Comment 7

[Robert Chira [:RobertC]]

Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

Fixed conflicts and desktop failure.

Comment 8

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/d7cbd4abda9174e57722fc977e47f42fb54cc093

Comment 9

[Florin Strugariu [:Bebe]]

Can we get this to v2.1

Comment 10

[Robert Chira [:RobertC]]

The move to element does not work as expected on 2.1. I tried using flick(), but that didn't work either. Because of this the uplift would require additional investigation to get it to work and since we are going to stop testing on 2.1 soon I propose not uplifting the test.