Closed Bug 1086277 Opened 5 years ago Closed 5 years ago

Add a test for add & delete a divider on homescreen

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RobertC, Assigned: RobertC)

Details

Attachments

(1 file)

Implement test case to add and delete homescreen divider.
This will be done by moving an icon from the top to the bottom of the homescreen, then move it back up.

https://moztrap.mozilla.org/manage/case/13082/
https://moztrap.mozilla.org/manage/case/13096/
Attachment #8511987 - Flags: review?(viorela.ioia)
Attachment #8511987 - Flags: review?(jlorenzo)
Attachment #8511987 - Flags: review?(florin.strugariu)
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

This is a good start. I tested it and the test is working. I think we should refactor some things. I left comments in Github.
Attachment #8511987 - Flags: review?(jlorenzo) → review-
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

the pull looks like a good start
I will wait for the current issues to be fixed before I submit my final review
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

I updated the PR according to some of the comments left there.
Attachment #8511987 - Flags: review- → review?(jlorenzo)
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

LGTM!
Attachment #8511987 - Flags: review?(jlorenzo) → review+
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

Comments in the PR
Attachment #8511987 - Flags: review?(viorela.ioia) → review-
Comment on attachment 8511987 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25546

Fixed conflicts and desktop failure.
Attachment #8511987 - Flags: review- → review?(viorela.ioia)
Attachment #8511987 - Flags: review?(florin.strugariu) → review+
Can we get this to v2.1
Flags: needinfo?(robert.chira)
The move to element does not work as expected on 2.1. I tried using flick(), but that didn't work either. Because of this the uplift would require additional investigation to get it to work and since we are going to stop testing on 2.1 soon I propose not uplifting the test.
Flags: needinfo?(robert.chira)
Attachment #8511987 - Flags: review?(viorela.ioia)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s2]
You need to log in before you can comment on or make changes to this bug.