1086434 - Having open multiple outgoing call windows in the retry/cancel state makes the user unable to make/receive another call

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Start 2 FF profiles and login with 2 FxA accounts on each
2. From the 1st account call the second one
3. Press 'Cancel' in the incoming call window on the second account so that the retry/cancel is displayed in the outgoing call window on the first account 
4. Repeat steps 2-3 until you got 4 retry/cancel windows
5. Try to make another call

Actual results:
Unable to make another call from the 1st account. Nothing happens when clicking on the green call button. The 1st account is also no longer able to receive calls.

Comment 1

[Mark Banner (:standard8)]

I've dug into this a bit. The root cause is that for outgoing calls we're generating a url to open the window where the url is:

about:loop:conversation#outgoing/<id>

The <id> is a random number from 1 to 10. The code that opens the conversation window will switch to an existing window if the url is the same.

Hence, once you get about 3-5 windows open you're highly likely to get the same random number and the window "fails" to open.

Additionally, in this case, you the "user busy" code is also stuck in the busy state, so you can't open any more windows until you close the one with the original number.

Really, we should do a wider upgrade of how we fix our urls in the conversation window - so setting this dependent on bug 1090209.

Comment 2

[Mark Banner (:standard8)]

Attachment: Temporarily make the random number a big number whilst we fix the issue elsewhere.

Bug 1090209 will fix this properly by completely rewriting the id code that we use for windows.

This fix is mainly intended beta-only as I'm currently working on bug 1090209 - though we'll land it everywhere for testing & sanity purposes whilst we get bug 1090209 out.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8512797 [details] [diff] [review]
Temporarily make the random number a big number whilst we fix the issue elsewhere.

r=dmose

Comment 4

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: This could cause a user to have not closed an existing conversation window, but then not be able to open another one. There's approx a 1 in 10 chance of this happening.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8512797 [details] [diff] [review]
Temporarily make the random number a big number whilst we fix the issue elsewhere.

I'll land this on fx-team as soon as it re-opens, getting on the radar for now.

Approval Request Comment
[Feature/regressing bug #]: Direct Calling implementation for Loop
[User impact if declined]: There's a 1 in 10 chance that the user might try to open a second conversation window and not be able to, with no indication as to why. The user would have to close the other window(s) first, which they might not realise to do.
[Describe test coverage new/current, TBPL]: This is changing an integer that is randomly generated and inserted into a url and I hadn't realised that it needed to be a different url for each window. Hence no easy test coverage as we're dealing with random numbers. We can obviously test on landing.
[Risks and why]: Low. Simple change to increase the randomness and reduce the likelyhood of this happening to approx 1 in 100 million. Bug 1090209 will implement the longer term fix probably from 35 onwards.
[String/UUID change made/needed]: None.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/160e9f511375

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/160e9f511375

Comment 8

[Maire Reavy [:mreavy]]

Hi Pauly, Can you test/verify this today with today's Nightly?  Thanks!

Comment 9

[Paul Silaghi, QA [:pauly]]

Works fine with more than 20 retry/cancel windows open.
36.0a1 (2014-10-29) Win 7

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8512797 [details] [diff] [review]
Temporarily make the random number a big number whilst we fix the issue elsewhere.

Beta+
Aurora+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0aef2821cb60
https://hg.mozilla.org/releases/mozilla-beta/rev/a7a6e6465c30

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Verified on aurora and beta from tbpl builds, Linux.

Comment 13

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b9, 35.0a2 (2014-11-14) Win 7