Closed Bug 1086523 Opened 10 years ago Closed 10 years ago

(App-grouping) Collapsed group and group header should be more compact

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S8 (7Nov)
Tracking Flags:
Tracking Status
b2g-master --- verified

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Remove group naming and make group headers and collapsed groups more compact
46 bytes, text/x-github-pull-request
crdlc
: review+
Details | Review 
v0.4 of the app-grouping spec shows a more compact group-header and more compact collapsed groups.
I expect this may need some test tweaking for the grouping marionette tests, but I don't think the code will change.
Attachment #8511072 - Flags: review?(crdlc)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
Comment on attachment 8511072 [details] [review]
Remove group naming and make group headers and collapsed groups more compact

LGTM Chris, thanks
Attachment #8511072 - Flags: review?(crdlc) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/ccf8a1920459bd662d0255a3bbc8ba117114e37e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on the latest Nightly Flame 3.0 build

Results: The collapsed group has no group header and is more compact

Device: Flame 3.0 (KK - Nightly - Full Flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-master: --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: