1086584 - Localized builds page "beta builds" link anchor has no target

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Paul [:pmac] McLanahan]

The link on the page "New languages still in beta" should cause the page to scroll to the table of beta locales, but it no longer does. I see the target name in a class on a div around that table, and my suspicion is that this used to be an "id" attribute, which would work. Likely fix is to add an "id" attribute to this div so that the link can work again. This is likely an issue on all "/{product_name}/all/" pages, which do share a template. But I found it here:

https://www.mozilla.org/en-US/firefox/organizations/all/

Comment 1

[Vasudev Patel]

i would like to work on it
i am new to this ,, can u help me ??

Comment 2

[Paul [:pmac] McLanahan]

Yes indeed. Thanks for offering. Documentation for getting started with bedrock (the codebase for mozilla.org) is here:

http://bedrock.readthedocs.org/

The code is on github:

https://github.com/mozilla/bedrock/

The particular template in question is:

https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/all.html#L72

The hightlighted line is the link that's not working, so you'll need to find and add an ID to fix it I believe. The easiest way to get things running for testing your changes is Cloud9, the instructions for which are in the "Quickstart" section of the docs (linked above).

Thanks for the help! If you have further questions you can ask here, or find us on mozilla's IRC servers in the #www channel.

Comment 3

[Vasudev Patel]

how can i preview the changes on cloud9 ??
which is the file which i should run ??

Comment 4

[Paul [:pmac] McLanahan]

Cloud9 usage docs are in the quickstart guide:

http://bedrock.readthedocs.org/en/latest/quickstart.html

Comment 5

[Vasudev Patel]

which is the main file which i should run to get preview of the web page ??

Comment 6

[Vasudev Patel]

i am getting weird prewiew of /bedrock/bedrock/firefox/templates/firefox/all.html i don't know why ??
there must me kind of main file to run ...
but i changed line line 114 ,, instead of class="localized-testing" i put id="localized-testing" and the link seem to work fine now..
how can i provide a patch i am new and don't know how to ???

Comment 7

[meghjp]

Done! See pull request : https://github.com/mozilla/bedrock/pull/2423

Working on my c9 : http://bedrock-c9-meghprkh.c9.io/en-US/firefox/organizations/all/#localized-testing
(I am new to c9 and don't know whether this link works continuously

This all the other links
Editor : https://ide.c9.io/meghprkh/bedrock
Application : https://bedrock-c9-meghprkh.c9.io
Preview : https://preview.c9.io/meghprkh/bedrock

Comment 8

[Paul [:pmac] McLanahan]

Brilliant! Works for me. And the c9 link worked as well :) I'll comment on the pull-request as well.

Thanks!

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e4b5c87cae92b91b9e00cd8f400217342189d531
Fix bug 1086584: Add ID for anchor link in firefox/all template.