Closed Bug 1086662 Opened 6 years ago Closed 6 years ago

Add a test that ensures test_camera_capture_video.py saves a video file of a minimum size

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

()

Details

Attachments

(1 file, 3 obsolete files)

This is moztrap test https://moztrap.mozilla.org/manage/case/2478/

No idea how to check if the sound of the video is working, though.
Component: Gaia::UI Tests → Gaia::Video
From the Moztrap test:
Prerequisite: A video has been recorded with sound, using the onboard camera.

    Open the video app.

    Select recently recorded video.

    Video should play back. There should be visuals with no gap. There should be continuous sound in sync with the video, also with no gaps.
This is rather lame, this is just adding test_play_webm_video.py on top of test_camera_capture_video.py.

I'm not sure how useful that is. This tests at least that the recorded video is playable. 
But I don't know if testing if there are problems with the sound or video smoothness is possible.
Attachment #8514694 - Flags: feedback?(zcampbell)
Martijn, I tend to agree.. The two test cases taken separately will be more stable and reliable.

Something you may want to do is validate more strictly that the video file is recorded onto the sdcard, that its file size is >0 for example.

I don't think that testing the sound or video is easily done, however perhaps as an addition to test_play_*_video you could check that the correct audio channel is being opened (but that'd be a separate bug).
Attachment #8514694 - Flags: feedback?(zcampbell)
QA Whiteboard: fxosqa-auto-s3, fxosqa-auto-points=8,
Flags: in-qa-testsuite?(martijn.martijn)
Attached patch capture.diff (obsolete) — Splinter Review
So something like this?

If you agree with this, I would need to also change the other callers of getFiles.
Attachment #8514694 - Attachment is obsolete: true
Attachment #8517355 - Flags: feedback?(zcampbell)
Summary: Write an automated test for "Play the video you recorded. Check for video and sound" manual smoketest → Add a test that ensures test_camera_capture_video.py saves a video file of a minimum size
Component: Gaia::Video → Gaia::UI Tests
(In reply to Zac C (:zac) from comment #3)
> I don't think that testing the sound or video is easily done, however
> perhaps as an addition to test_play_*_video you could check that the correct
> audio channel is being opened (but that'd be a separate bug).

I filed bug 1094144 for this.
Comment on attachment 8517355 [details] [diff] [review]
capture.diff

Yes I think something like that but we'd want the video_files property to be a Python list so we can read it using Python syntax.

As this will break a lot of other tests it will need to be of high importance to be worth the risk.
Attachment #8517355 - Flags: feedback?(zcampbell)
Looking at what might break, I see only sdcard_files that is prone to breakage.
tests/functional/contacts/test_export_contacts_to_sdcard.py
tests/functional/contacts/test_import_contacts_from_sdcard.py 
The rest, music_files, picture_files, video_files, media_files, seem to work (or isn't used at all).
QA Whiteboard: fxosqa-auto-s3, fxosqa-auto-points=8, → fxosqa-auto-s4, fxosqa-auto-points=8, fxosqa-auto-from-s3
Attachment #8517355 - Attachment is obsolete: true
Attachment #8522213 - Flags: review?(zcampbell)
Comment on attachment 8522213 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26114

r-, if we make a small change to the atom then we can do everything in Python within the test instead of trying to convert data types.
Attachment #8522213 - Flags: review?(zcampbell) → review-
Attached file capture3
Like this?
Attachment #8522213 - Attachment is obsolete: true
Attachment #8526142 - Flags: review?(zcampbell)
Comment on attachment 8526142 [details] [review]
capture3

r+, Yep that's great, very clean!
Attachment #8526142 - Flags: review?(zcampbell) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
QA Whiteboard: fxosqa-auto-s4, fxosqa-auto-points=8, fxosqa-auto-from-s3 → fxosqa-auto-s4, fxosqa-auto-points=8, fxosqa-auto-from-s3, fxosqa-auto-from-s2
Flags: in-qa-testsuite?(martijn.martijn) → in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.