Closed Bug 1086679 Opened 10 years ago Closed 10 years ago

Remove all the scrollIntoView!!

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

Details

Attachments

(1 file)

github pr
46 bytes, text/x-github-pull-request
Bebe
: review+
viorela
: review+
Details | Review 
Let's see what we set on fire when we remove all of these.
adhoc on m-i build (as this patch isn't on m-c just yet):
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/221/console
Attached file github pr — 
Some could not be removed for various reasons, for example when checking the wifi text, the element needs to be in view.

Running another adhoc:
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/255/console
Attachment #8513565 - Flags: review?(viorela.ioia)
Attachment #8513565 - Flags: review?(robert.chira)
Attachment #8513565 - Flags: review?(florin.strugariu)
Comment on attachment 8513565 [details] [review]
github pr

Lgtm
Attachment #8513565 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8513565 [details] [review]
github pr

LGTM
Attachment #8513565 - Flags: review?(robert.chira)
Attachment #8513565 - Flags: review?(florin.strugariu)
Attachment #8513565 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/eda6bac861e7e8d8c0d66dccc81d7d72f035fb8f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8513565 - Flags: review?(robert.chira)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: