Closed Bug 1086714 Opened 9 years ago Closed 9 years ago

Change test_selection_underline.html's log output so that it can be used with reftest-analyzer.xhtml

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

patch
3.27 KB, patch
dholbert
: review+
jwatt
: checkin+
Details | Diff | Splinter Review 
      No description provided.
Getting reftests failing under this test, similar to bug 1084650. Let's fix the test so that it's output can be compared with the analyzer.
Attached patch patch — — Splinter Review 

        Attachment #8508863 -
        Flags: review?(dholbert)

    
    

    
  
Comment on attachment 8508863 [details] [diff] [review]
patch

>diff --git a/layout/generic/test/test_selection_underline.html b/layout/generic/test/test_selection_underline.html
>+    var description = "(selection: " + aTest.selection.typeName +
>+                      ", style: " + aTest.decoration.styleName +
>+                      ", relativeSize: " + aTest.decoration.relativeSize +
>+                      ", font: " + aTest.font.family +
>+                      ", default font size: " + aTest.font.defaultSize + ")";
>+ 
  ^
Nit: whitespace on blank line here (a single space character) -- remove.

r=me

        Attachment #8508863 -
        Flags: review?(dholbert) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e1f058f9565b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

          You need to log in
          before you can comment on or make changes to this bug.