1086988 - [2.1][l10n][Usage] Multiple locales: If byte count reaches 3 digits it overlaps the source text next to it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Robert Mead [:RobertM]]

Attachment: 2014-10-21-14-34-08.png

Description:
After setting up the 'Usage' app, if the byte count in the rows below the graph reach 3 digits, the text overlaps the description text(ex:Mobile usage, Wi-Fi usage) next to it.
   
Prereq:
Have a valid SIM card inserted in the device and set language to Basque.

Repro Steps:
1) Update a Flame device to BuildID: 20141021001201
2) Tap the 'Usage' app and go through set up process
3) Tap rocket bar and go to google.
4) Try access a website then check usage app.
5) if you usage is less than 100kb, access another website.
6) Repeat step 5 until you are greater then 100kb but less than 1mb
7) Open 'Usage' app and observe usage rows
  
Actual:
The Byte count overlaps into the source usage text field.
  
Expected: 
The Byte count does not overlap into the source usage text field.
  

Flame 2.1(319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141021001201
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

  
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/14717/
See attached: screenshot

Comment 1

[Robert Mead [:RobertM]]

This issue does NOT occur on Flame 2.0(319mb)

When in the usage app, once the byte count reaches 3 digits before the decimal, the byte count and usage source text do not overlap.

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141021000201
Gaia: 63b56a7a7453726b9e12ad1afe02c68c83c5aeca
Gecko: 40584eecdc75
Version: 32.0 (2.0)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Regression, flagging UX

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:
Basque is a critical Tako shipping locale

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Actually happens on multiple shipping locales

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: identifiable regression

Comment 7

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 8

[Paco Rampas [:paco]]

Attachment: usage-digits-truncate.png

Comment 9

[Paco Rampas [:paco]]

Attachment: usage-digits-truncate.png

Comment 10

[Amy Lee [:amylee] UX]

Comment on attachment 8510073 [details]
usage-digits-truncate.png

This looks good to me. Thanks for the fix.

Comment 11

[Marina Rodríguez [:mai]]

Comment on attachment 8509396 [details] [review]
patch in github

LGTM. Thanks!

Comment 12

[Stephany Wilkes]

Clearing flag since Amy has given this a +.

Comment 13

[Amy Lee [:amylee] UX]

Comment on attachment 8510073 [details]
usage-digits-truncate.png

Flagging UX for review as well.

Comment 14

[Paco Rampas [:paco]]

Comment on attachment 8509396 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): text isn't truncate
[User impact] if declined: bad visualization
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Hi Paco,

this has the r+, do you need someone to push it to master?

Comment 16

[katieC]

Ni'ing Juwei as she is now the UX designer for Usage app

Comment 17

[katieC]

Comment on attachment 8510073 [details]
usage-digits-truncate.png

ui+ based on above png. [clearing juwei's NI]

Comment 18

[Paco Rampas [:paco]]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #15)
> Hi Paco,
> 
> this has the r+, do you need someone to push it to master?

No, I was waiting for showing all green on gaia-try. I am going to merge :):)

Comment 19

[Paco Rampas [:paco]]

merged: a26704ed33f9251d360675a2083dcf9f2510bbd9

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/fde08d847486a37ccd1551112c2a132c4fc6b936

Comment 21

[sarsenyev]

Verified the issue is fixed on 2.2 and 2.1 builds,
The string has ellipses now and no overlapping appears on the screen with 3+ digits 

Device: Flame 2.2 Master KK
BuildID: 20141030040201
Gaia: 0dfc1996eb583c8b507a82bf6b8319624bba23ea
Gecko: 80e18ff7c7b2
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 KK
BuildID: 20141030001201
Gaia: 3e585d8be5e2dffc376f83313299c9b6d53c3db4
Gecko: b643d78a23c6
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0