Closed Bug 1087049 Opened 9 years ago Closed 9 years ago

Test draft review request deletion

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

MozReview Request: bz://1087049/gps
42 bytes, text/x-review-board-request
smacleod
: review+
mcote
: review+
Details 
Code coverage reveals we don't have test coverage of deleting draft review requests. Let's add a test.
/r/277 - reviewboard: add a command for discarding a draft review request
/r/278 - reviewboard: add a test around deleting draft review requests (bug 1087049)

Pull down these commits:

hg pull review -r 5ee1cce0da3ebf4b3a43c283918e9dd62c3b54ec
Comment on attachment 8509101 [details]
MozReview Request: bz://1087049/gps

Looks like the commits tab is broken and r? flags aren't making it here :/
Attachment #8509101 - Flags: review?(smacleod)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #8509101 - Flags: review+
Will leave review open in case smacleod cares to post review.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8509101 [details]
MozReview Request: bz://1087049/gps

Took a quick glance, looked fine.
Attachment #8509101 - Flags: review?(smacleod) → review+
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.