1087144 - Log an xpcshell test crash with log_crashes rather than check_for_crashes

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I have a patch for this, will land after bug 1033126.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Log crashes in xpcshell via log_crashes rather than checkForCrashes

Comment 2

[Chris Manchester (limited bugmail, email directly)]

bc pinged me about this this week, the patch here looks reasonable I'll rebase and push to try. Setting ni? as a reminder.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Try push with an intentional crash in test_sample.js: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c6504a80fad663b61993c958d52040efe8d77d8

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Aha, there was an issue in the original patch. Here's an updated try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee3f4442df34c3ac9df517a4ae3ba12dbfbdaf13

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1087144 - Log crashes in xpcshell via log_crashes rather than checkForCrashes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23858ba6c81b
Log crashes in xpcshell via log_crashes rather than checkForCrashes r=gbrown

Comment 7

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cbuild-linux64-asan-fuzzing%2Fopt%2C%28bof%29&fromchange=23858ba6c81bd4986d84af2e394698fcefa5896e&tochange=d6630a17c2fab5517d72cf87b4afe6a2bff3b8ee&selectedJob=250188981

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250188981&repo=autoland&lineNumber=39465

Backout link: https://hg.mozilla.org/integration/autoland/rev/d6630a17c2fab5517d72cf87b4afe6a2bff3b8ee

task 2019-06-05T17:32:33.161Z] 17:32:33 INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testUnicodeInAssertMethods PASSED
[task 2019-06-05T17:32:33.161Z] 17:32:33 INFO - =================================== FAILURES ===================================
[task 2019-06-05T17:32:33.161Z] 17:32:33 INFO - _____________________ XPCShellTestsTests.testCrashLogging ______________________
[task 2019-06-05T17:32:33.161Z] 17:32:33 INFO - self = <selftest.XPCShellTestsTests testMethod=testCrashLogging>
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - def testCrashLogging(self):
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - """
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - Test that a crashing test process logs a failure.
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - """
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - self.writeFile("test_crashes.js", TEST_CRASHING)
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - self.writeManifest(["test_crashes.js"])
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - self.assertTestResult(False)
[task 2019-06-05T17:32:33.162Z] 17:32:33 INFO - self.assertEquals(1, self.x.testCount)
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - self.assertEquals(0, self.x.passCount)
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - self.assertEquals(1, self.x.failCount)
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - > self.assertInLog("\nPROCESS-CRASH")
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - ../testing/xpcshell/selftest.py:957:
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - ../testing/xpcshell/selftest.py:552: in assertInLog
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - self._assertLog(s, True)
[task 2019-06-05T17:32:33.163Z] 17:32:33 INFO - ../testing/xpcshell/selftest.py:546: in _assertLog
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - ========""" % (s, "expected" if expected else "not expected", l))
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E AssertionError: Value
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E PROCESS-CRASH expected in log:
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E ========
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E runxpcshelltests.py | using symbolizer at /builds/worker/workspace/build/src/obj-firefox/dist/bin/llvm-symbolizer
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E Found node at /builds/worker/workspace/build/src/node/bin/node
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E Found moz-http2 at /builds/worker/workspace/build/src/testing/xpcshell/moz-http2/moz-http2.js
[task 2019-06-05T17:32:33.164Z] 17:32:33 INFO - E Running tests sequentially.
[task 2019-06-05T17:32:33.165Z] 17:32:33 INFO - E SUITE-START | Running 1 tests
[task 2019-06-05T17:32:33.165Z] 17:32:33 INFO - E profile dir is /tmp/xpcshell/xpcshellprofile
[task 2019-06-05T17:32:33.165Z] 17:32:33 INFO - E TEST-START | test_crashes.js
[task 2019-06-05T17:32:33.165Z] 17:32:33 WARNING - E TEST-UNEXPECTED-FAIL | test_crashes.js | xpcshell return code: 1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f86a54ce263e
Log crashes in xpcshell via log_crashes rather than checkForCrashes r=gbrown

Comment 9

[Chris Manchester (limited bugmail, email directly)]

We can't look for "PROCESS-CRASH" in the selftests on non-crashreporter builds.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f86a54ce263e