Disabled and removed breakpoint re-appears as disabled after page reload

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: offbynone, Unassigned)

Tracking

(Blocks: 1 bug)

36 Branch
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-backlog][difficulty=easy])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141022030202

Steps to reproduce:

add a breakpoint,
right click the breakpoint and disable
right click the breakpoint and remove
reload the page


Actual results:

the breakpoint re-appears as a disabled breakpoint.


Expected results:

the breakpoint should still be removed.

Updated

4 years ago
Component: Untriaged → Developer Tools: Debugger
Summary: removed breakpoint re-appears after page reload → Disabled and removed breakpoint re-appears as disabled after page reload
Blocks: 1074182
Can you provide more details, such as what URL you are testing with and where the breakpoint was set?
Flags: needinfo?(offbynone)

Comment 2

4 years ago
You can test with any webpage, just add a breakpoint anywhere then disable/remove it and reload the page.
Same behavior in previous versions like FF31.
Hmm, fair enough!  It does indeed happen even on this bug page.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(offbynone)
I can still repro this - setting devedition-40. Eddy - can you add a difficulty whiteboard to this? eg

[difficulty=easy] ( or medium, or hard )
Priority: -- → P1
Whiteboard: [devedition-40]
Going to look into this.
Assignee: nobody → ejpbruel
Created attachment 8616720 [details] [diff] [review]
patch

Here's a patch that fixes the problem, with comments to explain what is going on.
Attachment #8616720 - Flags: review?(jlong)
Comment on attachment 8616720 [details] [diff] [review]
patch

Review of attachment 8616720 [details] [diff] [review]:
-----------------------------------------------------------------

The breakpoint code is crazily terrible and ugh. For others who see this bug, I have a complete refactoring underway of the frontend sources & breakpoints UI (the UI will stay the same, but how data is propagated is totally different). None of this kind of code exists in the new version.

I hope to land it soon-ish (maybe a month) but we can go ahead and land this for now.
Attachment #8616720 - Flags: review?(jlong) → review+
Whiteboard: [devedition-40] → [polish-backlog]
Whiteboard: [polish-backlog] → [polish-backlog][difficulty=easy]
Assignee: ejpbruel → nobody
this is fixed in the new debugger
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.