1087312 - Disabled and removed breakpoint re-appears as disabled after page reload

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Off By None]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141022030202

Steps to reproduce:

add a breakpoint,
right click the breakpoint and disable
right click the breakpoint and remove
reload the page


Actual results:

the breakpoint re-appears as a disabled breakpoint.


Expected results:

the breakpoint should still be removed.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Can you provide more details, such as what URL you are testing with and where the breakpoint was set?

Comment 2

[Loic]

You can test with any webpage, just add a breakpoint anywhere then disable/remove it and reload the page.
Same behavior in previous versions like FF31.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm, fair enough!  It does indeed happen even on this bug page.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I can still repro this - setting devedition-40. Eddy - can you add a difficulty whiteboard to this? eg

[difficulty=easy] ( or medium, or hard )

Comment 5

[Eddy Bruel [:ejpbruel]]

Going to look into this.

Comment 6

[Eddy Bruel [:ejpbruel]]

Attachment: patch

Here's a patch that fixes the problem, with comments to explain what is going on.

Comment 7

[James Long (:jlongster)]

Comment on attachment 8616720 [details] [diff] [review]
patch

Review of attachment 8616720 [details] [diff] [review]:
-----------------------------------------------------------------

The breakpoint code is crazily terrible and ugh. For others who see this bug, I have a complete refactoring underway of the frontend sources & breakpoints UI (the UI will stay the same, but how data is propagated is totally different). None of this kind of code exists in the new version.

I hope to land it soon-ish (maybe a month) but we can go ahead and land this for now.

Comment 8

[Eddy Bruel [:ejpbruel]]

Try push for the above patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cff75d9be49

Comment 9

[Jason Laster [:jlast]]

this is fixed in the new debugger