1087322 - New mail notification on OS X shuts down during xpcom-shutdown, should use profile-before-change

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:Irving Reid (No longer working on Firefox)]

Was debugging something else and noticed a bunch of "objects kept alive during shutdown" error messages spew out, and noticed that they came after the new mail notification service shut down (during xpcom-shutdown).

Since notification depends on folders, and folders are in the profile, this service should shut down during profile-before-change.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Shut down new mail notification during profile-before-change

Comment 2

[Kent James (:rkent)]

Comment on attachment 8509461 [details] [diff] [review]
Shut down new mail notification during profile-before-change

Review of attachment 8509461 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this makes sense. There is at least one other place where this should be done, here: http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendLater.cpp#157

New bug, or add to this?

Comment 3

[:Irving Reid (No longer working on Firefox)]

(In reply to Kent James (:rkent) from comment #2)
> Comment on attachment 8509461 [details] [diff] [review]
> ... There is at least one other place where this should be
> done, here:
> http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/
> nsMsgSendLater.cpp#157
> 
> New bug, or add to this?

Ugh, that's a mess. Bug 1088152.

https://hg.mozilla.org/comm-central/rev/1a8314ae0ae5