Closed
Bug 1087322
Opened 10 years ago
Closed 10 years ago
New mail notification on OS X shuts down during xpcom-shutdown, should use profile-before-change
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
Tracking | Status | |
---|---|---|
thunderbird36 | --- | fixed |
People
(Reporter: Irving, Assigned: Irving)
References
Details
Attachments
(1 file)
1.80 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
Was debugging something else and noticed a bunch of "objects kept alive during shutdown" error messages spew out, and noticed that they came after the new mail notification service shut down (during xpcom-shutdown). Since notification depends on folders, and folders are in the profile, this service should shut down during profile-before-change.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8509461 -
Flags: review?(kent)
Comment 2•10 years ago
|
||
Comment on attachment 8509461 [details] [diff] [review] Shut down new mail notification during profile-before-change Review of attachment 8509461 [details] [diff] [review]: ----------------------------------------------------------------- Yes this makes sense. There is at least one other place where this should be done, here: http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendLater.cpp#157 New bug, or add to this?
Attachment #8509461 -
Flags: review?(kent) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Kent James (:rkent) from comment #2) > Comment on attachment 8509461 [details] [diff] [review] > ... There is at least one other place where this should be > done, here: > http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/ > nsMsgSendLater.cpp#157 > > New bug, or add to this? Ugh, that's a mess. Bug 1088152. https://hg.mozilla.org/comm-central/rev/1a8314ae0ae5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Updated•9 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•