Closed Bug 1087328 Opened 10 years ago Closed 10 years ago

The try commit hook can inadvertently flag commit messages as unacceptable

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: gps)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/579] )

Attachments

(2 files, 1 obsolete file)

MozReview Request: hghooks: test for failed try syntax detection
38 bytes, text/x-review-board-request
emorley
: review+
Details
MozReview Request: hghooks: don't match try syntax in subwords (bug 1087328)
38 bytes, text/x-review-board-request
emorley
: review+
Details 
Ran into this today:
"Bug 1084180 - Refine RemoveEntry: Not only remove this entry but also its children if exist. r=dhylands"

The hook thinks this contains try syntax.
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/579]
Regular expressions: now you have two problems.
Attached file MozReview Request: bz://1087328/gps (obsolete) — 

        Attachment #8514536 -
        Flags: review?(emorley)

    
    

    
  
/r/123 - hghooks: test for failed try syntax detection
/r/125 - hghooks: don't match try syntax in subwords (bug 1087328)

Pull down these commits:

hg pull review -r b5bfe83ca6bbdfccc739fcb6935e49601a4f6ab3

    
  

        Attachment #8514536 -
        Flags: review?(emorley) → review+

    
  
Assignee: nobody → gps
Status: NEW → ASSIGNED

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/579] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/579]

    
  
Depends on: 1127316

    
    

    
  

        Attachment #8514536 -
        Attachment is obsolete: true

        Attachment #8618433 -
        Flags: review+

        Attachment #8618434 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: