1087349 - Platform row is duplicated after every refresh for rows where the platform name is guessed

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

For this result set:
https://treeherder.mozilla.org/ui/#/jobs?repo=date&revision=0c480befd4ea

When you first open the page, there are no duplicate platform rows (for the job results).
However each time the UI refreshes, rows where the platform name was guessed (a la bug 1087341) are duplicated.

See screenshots.

Comment 1

[Ed Morley [:emorley]]

Attachment: Screenshot - initial pageload

Comment 2

[Ed Morley [:emorley]]

Attachment: Screenshot - after 5-10 mins

Comment 4

[Ed Morley [:emorley]]

We hit this again with bug 1078265 / bug 1073772.

Comment 5

[Jonathan French (:jfrench)]

Ryan hit this again today with l10n repacks.

Comment 6

[Cameron Dawson [:camd]]

In these cases, there was a space in the aggregate platformId that was generated.  Then when we went to find that with JQuery, we couldn't (spaces are invalid).  So we added the new one.  this fix is just to ensure there are no spaces in the aggregate platform id.

Comment 7

[Cameron Dawson [:camd]]

Attachment: ui PR

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8588793 [details] [review]
ui PR

Looks reasonable, thanks for iterating on this with me!

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/a1c1c9aded0d1f1745ebf76b904446d31f34d3c4
Bug 1087349 - fix platform duplication on guessed platform names

Ensure HTML aggregate ids have no spaces.

Comment 10

[Cameron Dawson [:camd]]

Ryan saw this on stage again this morning with a platform that had a "." in it.

Comment 11

[Cameron Dawson [:camd]]

Attachment: ui PR 2

Comment 12

[Cameron Dawson [:camd]]

Apparently just escaping certain characters with a ``\`` doesn't work with DOM ids.  I tested this out with several characters.  So now I just replace them with a ``-`` character and it works great.

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/60d1a92e06ac8008f7a1e47c5ca266ab4c55fbb0
Bug 1087349 - replace characters instead of escaping them

Ends up escaping characters in DOM ids didn’t work well.  This now
replaces them with hyphens, which DOES work well.

Comment 14

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8a5db6d00b4395387b54a8670e59935746d6254e
Bug 1087349 - fix platform duplication on guessed platform names

Ensure HTML aggregate ids have no spaces.

https://github.com/mozilla/treeherder/commit/e7ff0b0b9d341c6bce3f9c74ffa1680c9d380b8a
Bug 1087349 - replace characters instead of escaping them

Ends up escaping characters in DOM ids didn’t work well.  This now
replaces them with hyphens, which DOES work well.