Closed Bug 1087440 Opened 10 years ago Closed 6 years ago

Internet sharing (tethering) doesnt use the correct APN.

Categories

(Firefox OS Graveyard :: Wifi, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: juanjose.iglesias, Unassigned)

Details

Attachments

(3 files)

When the tethering opction is actived in the device, the apn setting should change from default apn to the registered apn profile
in tethering settings. 

In the case of Movistar ES SIM, the APN must changed from telefonica.es (default data apn profile) to movistar.es 
(default tethering apn profile). But when internet sharing is activated, the APN doesnt change and continue using telefonica.es

Add two log: 
- WIFIInternetSharing_root: log from device which actives the internet sharing. 
- WIFIInternetSharing_device: log form device which uses the tethering connection.

I have used a flame master (Gecko 719072f Gaia 3c90141).
Assignee: nobody → alberto.crespellperez
As detailed in https://bugzilla.mozilla.org/show_bug.cgi?id=960865#c22 there are two requisites in order to enable dun tethering:

- Build with iproute2.

- Gecko checks if dun is enabled by reading the android property 'ro.tethering.dun_required', the property must be defined with value '1'.

Our flame Telefonica builds are using iproute2 but that property is not defined.
Is there a way to easily enable the property for all builds of Firefox OS?
Flags: needinfo?(htsai)
Assignee: alberto.crespellperez → nobody
(In reply to Albert [:albert] from comment #4)
> Is there a way to easily enable the property for all builds of Firefox OS?

The way should be to have this property defined in makefile, and rebuild it :(
Flags: needinfo?(htsai)
Hi QuYi:

FYI, learned this issue and confirmed w/ Hsin-Yi about comment#5 that need your effort to fix.
Flags: needinfo?(yi.qu)
Dear wehuang@mozilla.com,
   the ro.tethering.dun_required only can be used on mozilla ril.
   But our device is using qcom ril.  
   And your patch is only effect after define MOZ_B2G_RIL.
Hi Wesly,

Per comment#7, it needs Mozilla and Qualcom work together to support this feature.

Please help to push this case.

Thanks.
Flags: needinfo?(wehuang)
I guess we need vendor RIL support. Could you please help here? We need vendor RIL to take into account that DUN profile is available for DUN connections.
Flags: needinfo?(mvines)
Flags: needinfo?(anshulj)
(discussing offline)
Flags: needinfo?(mvines)
Flags: needinfo?(anshulj)
(discussing offline)
(In reply to buri.blff from comment #7)
> Dear wehuang@mozilla.com,
>    the ro.tethering.dun_required only can be used on mozilla ril.
>    But our device is using qcom ril.  
>    And your patch is only effect after define MOZ_B2G_RIL.

Can you please try enabling ro.tethering.dun_required as requested and re-test.  If it doesn't work still then please raise an SR for support.
(In reply to Michael Vines [:m1] [:evilmachines] from comment #12)
> Can you please try enabling ro.tethering.dun_required as requested and
> re-test.  If it doesn't work still then please raise an SR for support.

Dears  Michael,

  Only enabling ro.tethering.dun_required can't make it works. And we think it must modified something in NetworkManager.js.
Dear  Beatriz,

  In mozilla's code, it only support for it's RIL. We think mozilla must support other's RIL(qcom) in  the file NetworkManager.js.
Flags: needinfo?(beatriz.rodriguezgomez)
Dear  Hsin-Yi, 

  Could you help check the file NetworkManager.js and make it use qcom  RIL. Thanks.
Flags: needinfo?(htsai)
Hsin-Yi, could you please help and check comment 15?
Flags: needinfo?(beatriz.rodriguezgomez)
Tested ro.tethering.dun_required with commercial ril and it works on v2.0, no changes required.

With that property enabled, ril will setup a data call with the APN defined in settings > "Cellular & Data" > "Tethering settings" > APN. Please ensure that this setting is properly set.


I did find that there is a bug in 2.2 that breaks this feature (bug 1106656), but this shouldn't affect v2.0 unless some patches were back-ported.
(In reply to pgravel from comment #17)
> Tested ro.tethering.dun_required with commercial ril and it works on v2.0,
> no changes required.

Dear pgravel,
  
It only use ro.tethering.dun_required if definied MOZ_B2G_RIL. You may check the code
https://github.com/mozilla/gecko-dev/blob/b2g32_v2_0/dom/system/gonk/NetworkManager.js#L688

Now we could remove the MOZ_B2G_RIL limit about DUN, but we can't  known Whether it brings new issues.
Hi Ray, is MOZ_B2G_RIL not defined in your build?  It should be.
(In reply to Michael Vines [:m1] [:evilmachines] from comment #19)
> Hi Ray, is MOZ_B2G_RIL not defined in your build?  It should be.

Hi Michael, Our base code from qcom doesn't defined the MOZ_B2G_RIL. If need, please tell us how to do. Thanks.
If MOZ_B2G_RIL (eg, --enable-b2g-ril) was not defined then the device could not make any phone calls/SMS/etc.  MOZ_B2G_RIL will be defined within gecko/configure.in during the start of normal Gecko build, there's nothing needed to explicitly define it in gonk-misc/default-gecko-config or elsewhere.
(In reply to Michael Vines [:m1] [:evilmachines] from comment #21)
> If MOZ_B2G_RIL (eg, --enable-b2g-ril) was not defined then the device could
> not make any phone calls/SMS/etc.  MOZ_B2G_RIL will be defined within
> gecko/configure.in during the start of normal Gecko build, there's nothing
> needed to explicitly define it in gonk-misc/default-gecko-config or
> elsewhere.

I'm sure the MOZ_B2G_RIL not defined in our code and the calls/SMS/etc works well.
Sorry, I am afraid I cannot help much for comment 15 as I know little about commRIL. Looks Phil is helping on the commril side. Canceling NI flag on me for now. Feel free to pin me again for further mozril or network manager questions, thanks.
Flags: needinfo?(htsai)
(In reply to Ray REN from comment #22)
> I'm sure the MOZ_B2G_RIL not defined in our code and the calls/SMS/etc works
> well.

Can you please confirm that MOZ_B2G_RIL is not getting defined by gecko/configure.in when building Gecko in your source tree?  As you can see from http://dxr.mozilla.org/mozilla-central/search?q=MOZ_B2G_RIL, if MOZ_B2G_RIL is not defined then most of the Gecko telephony code is disabled and that would be a serious problem for your device.  Note that MOZ_B2G_RIL has nothing to do with the RIL implementation being used, MOZ_B2G_RIL declares to the Gecko source code that a RIL exists.
(In reply to Albert [:albert] from comment #3)
> As detailed in https://bugzilla.mozilla.org/show_bug.cgi?id=960865#c22 there
> are two requisites in order to enable dun tethering:
> 
> - Build with iproute2.
> 
> - Gecko checks if dun is enabled by reading the android property
> 'ro.tethering.dun_required', the property must be defined with value '1'.
> 
> Our flame Telefonica builds are using iproute2 but that property is not
> defined.

how can we build project with iproute2??
(In reply to Michael Vines [:m1] [:evilmachines] from comment #12)
> (In reply to buri.blff from comment #7)
> > Dear wehuang@mozilla.com,
> >    the ro.tethering.dun_required only can be used on mozilla ril.
> >    But our device is using qcom ril.  
> >    And your patch is only effect after define MOZ_B2G_RIL.
> 
> Can you please try enabling ro.tethering.dun_required as requested and
> re-test.  If it doesn't work still then please raise an SR for support.

Dear mvines:
   After set  ro.tethering.dun_required  to true and define MOZ_B2G_RIL, we find the wifi tethering  can't be open.
   we have add the log:"can't open wifi tethering.txt"
  
   we find the log give follow error, then it disabled the wifi tethering.
 
  V/NatController(  206): runCmd(/system/bin/ip route flush cache) res=0
E/NatController(  206): Error setting route rules
the log for open wifi tethering fail
Flags: needinfo?(mvines)
(Clearing ni. As mentioned in comment 12, for non-Mozilla support on this issue please raise an SR or discuss with your TAM.  Thanks!)
Flags: needinfo?(mvines)
(In reply to Michael Vines [:m1] [:evilmachines] from comment #28)
> (Clearing ni. As mentioned in comment 12, for non-Mozilla support on this
> issue please raise an SR or discuss with your TAM.  Thanks!)

i have raise an SR:01841078
clear ni since this issue is followed by partner and QC offline w/ SR.
Flags: needinfo?(yi.qu)
Flags: needinfo?(wehuang)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: