1087461 - Tab overflow menu applies to "Tree Style Tabs" addon and any new tab ends up in the overflow menu

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Seth Fowler [:seth] [:s2h]]

A new regression in compatibility with the "Tree Style Tabs" addon has popped up on Nightly recently. Previously, you could never get a tab overflow menu (the menu that contains extra tabs that don't fit) with Tree Style Tabs; it doesn't really make sense for vertical tabs. Now, suddenly, the tab overflow menu is appearing, and any new tab I create ends up in it and doesn't appear in the regular list of tabs. I have to quit the browser, restart it, and restore my session to actually see a new tab.

It's probable this problem doesn't appear until you have enough tabs to cause the tab overflow menu to appear with the normal horizontal tab bar. I have a *lot* of tabs.

Comment 1

[Matthew N. [:MattN]]

I would recommend trying the Github version of TST since this sounds somewhat like the bug I fixed yesterday which started happening around the same time: https://github.com/piroor/treestyletab/pull/777

It seems like the download at http://piro.sakura.ne.jp/xul/xpi/confirm.cgi?treestyletab.xpi isn't updated yet. I can send you a build if you prefer.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Matt, I think you're right! You reference bug 979835 as the cause in the Github issue, and I just used mozregression to narrow things down to this range:

Last good revision: 62f0b771583c (2014-10-15)
First bad revision: a280a03c9f3c (2014-10-16)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=62f0b771583c&tochange=a280a03c9f3c

... which indeed contains bug 979835.

Thanks for finding and fixing the issue!

Comment 3

[Seth Fowler [:seth] [:s2h]]

Just checked, and indeed installing the Github version of Tree Style Tab fixes the problem. I've requested that the author push out the update.

Comment 4

[Dão Gottwald [:dao]]

Unless you've determined that there's a bug in our code, you should generally report add-on problems to add-on authors. They can come back to us if they hit a bug in our code base, but most of the time it's the add-on that needs to be fixed.