1087462 - Remove IRC nickname requirement

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P3)

Description

[Gregory Szorc [:gps]]

We're using review identifiers of bz://<bug>/<irc nick>. We require the client to define a mozilla.ircnick parameter in their hgrc to populate this nick name.

Now that we're using usernames and not email in the Review Board accounts table, we should be able to derive the appropriate username / irc nick from the Review Board username and not require the client to pass it as part of the review metadata.

There might be some edge cases around username change and possibly the "+" in the users without IRC nick syntax in Bugzilla. But I think inserting the Review Board username for the authenticated user should "just work."

Comment 1

[Gregory Szorc [:gps]]

This is a minor UX wart that only impacts first-time run (I think). Although, since we derive the parent review id bz:// URIs from this value, it is somewhat more important. We may split this into multiple parts...

Comment 2

[Mark Côté [:mcote]]

We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.

Comment 3

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.