Closed Bug 1087481 Opened 5 years ago Closed 5 years ago

implement Accessible::Name for proxies

Categories

(Core :: Disability Access APIs, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

No description provided.
Attachment #8509667 - Flags: review?(dbolter)
Comment on attachment 8509667 [details] [diff] [review]
teach atk to get the name for proxies

Review of attachment 8509667 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/AccessibleWrap.cpp
@@ +613,1 @@
>    accWrap->Name(name);

nit: Please indent.

::: accessible/ipc/DocAccessibleChild.cpp
@@ +56,5 @@
> +  if (!acc)
> +    return true;
> +
> +  acc->Name(*aName);
> +  return true;

I'm curious why you don't just have:
if (acc)
  acc->Name(*aName);

return true;
Attachment #8509667 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/34847ecea721
Assignee: nobody → tbsaunde+mozbugs
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.