1087481 - implement Accessible::Name for proxies

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: teach atk to get the name for proxies

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8509667 [details] [diff] [review]
teach atk to get the name for proxies

Review of attachment 8509667 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/AccessibleWrap.cpp
@@ +613,1 @@
>    accWrap->Name(name);

nit: Please indent.

::: accessible/ipc/DocAccessibleChild.cpp
@@ +56,5 @@
> +  if (!acc)
> +    return true;
> +
> +  acc->Name(*aName);
> +  return true;

I'm curious why you don't just have:
if (acc)
  acc->Name(*aName);

return true;

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34847ecea721