Closed Bug 1087492 Opened 5 years ago Closed 5 years ago

--disable-webrtc builds are busted, with "content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found"

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: dholbert, Assigned: ajones)

References

Details

Attachments

(2 files, 1 obsolete file)

My inbound build (with --disable-webrtc in mozconfig) is busted today, with this build error:
{
content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found

#include "mtransport/runnable_utils.h"
}

This file (TestMP4Reader.cpp) was added yesterday in bug 1034444.

It should not use runnable_utils.h, since runnable_utils.h is only available in WebRTC-enabled builds.

(Alternately, we should export runnable_utils.h even in non-WebRTC builds.)

See related bugs: bug 1070966, bug 1046263.
Summary: disable-webrtc builds are busted with "content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found" → --disable-webrtc builds are busted, with "content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found"
needinfo=k17e to determine how best to handle this.

In similar bug 1070966, we switched to NS_NewRunnableMethodWithArg. Maybe that or another method from http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsThreadUtils.h will suffice here?
Flags: needinfo?(ajones)
Thanks for the heads-up Daniel, but I'm afraid it was too late.
Here's my local bandaid to workaround the breakage.
Attachment #8509708 - Attachment description: temporary bandaid → temporary bandaid: don't build media gtests at all (not for landing)
Attachment #8510029 - Attachment is obsolete: true
Flags: needinfo?(ajones)
Attachment #8510057 - Flags: review?(edwin)
Comment on attachment 8510057 [details] [diff] [review]
Fix build break with --disable-webrtc

Review of attachment 8510057 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gtest/TestMP4Reader.cpp
@@ +19,3 @@
>  {
>  public:
> +  MOZ_DECLARE_REFCOUNTED_TYPENAME(TestBinding)

NS_INLINE_DECL_REFCOUNTING and nsRefPtr are preferred outside of gfx/, IIRC.

@@ +35,5 @@
>      EXPECT_EQ(NS_OK, resource->Open(nullptr));
>      decoder->SetResource(resource);
>  
>      reader->Init(nullptr);
>  

nit: extra line
Attachment #8510057 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/e1238bd7c4ea
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.