1087492 - --disable-webrtc builds are busted, with "content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

My inbound build (with --disable-webrtc in mozconfig) is busted today, with this build error:
{
content/media/gtest/TestMP4Reader.cpp:14:10: fatal error: 'mtransport/runnable_utils.h' file not found

#include "mtransport/runnable_utils.h"
}

This file (TestMP4Reader.cpp) was added yesterday in bug 1034444.

It should not use runnable_utils.h, since runnable_utils.h is only available in WebRTC-enabled builds.

(Alternately, we should export runnable_utils.h even in non-WebRTC builds.)

See related bugs: bug 1070966, bug 1046263.

Comment 1

[Daniel Holbert [:dholbert]]

needinfo=k17e to determine how best to handle this.

In similar bug 1070966, we switched to NS_NewRunnableMethodWithArg. Maybe that or another method from http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsThreadUtils.h will suffice here?

Comment 2

[Mats Palmgren (inactive)]

Attachment: temporary bandaid: don't build media gtests at all (not for landing)

Thanks for the heads-up Daniel, but I'm afraid it was too late.
Here's my local bandaid to workaround the breakage.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix build break with --disable-webrtc

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix build break with --disable-webrtc

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8510057 [details] [diff] [review]
Fix build break with --disable-webrtc

Review of attachment 8510057 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gtest/TestMP4Reader.cpp
@@ +19,3 @@
>  {
>  public:
> +  MOZ_DECLARE_REFCOUNTED_TYPENAME(TestBinding)

NS_INLINE_DECL_REFCOUNTING and nsRefPtr are preferred outside of gfx/, IIRC.

@@ +35,5 @@
>      EXPECT_EQ(NS_OK, resource->Open(nullptr));
>      decoder->SetResource(resource);
>  
>      reader->Init(nullptr);
>  

nit: extra line

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1238bd7c4ea

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1238bd7c4ea