1087498 - mozilla-central/accessible/ipc/DocAccessibleParent.cpp:47:14: warning: unused variable ‘id’ [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Daniel Holbert [:dholbert] (AFK Aug 23-25)]

Build warning in opt builds:
{
mozilla-central/accessible/ipc/DocAccessibleParent.cpp:47:14: warning: unused variable ‘id’ [-Wunused-variable]
}

This is from this variable:
> 46   for (uint32_t i = 0; i < consumed; i++) {
> 47     uint64_t id = aData.NewTree()[i].ID();
> 48     MOZ_ASSERT(mAccessibles.GetEntry(id));
> 49   }

As shown here, 'id' is indeed unused in opt builds.

Comment 1

[Daniel Holbert [:dholbert] (AFK Aug 23-25)]

Is this whole loop even useful in opt builds? (Does line 47 actually do anything, on its own?)
If yes, we should use DebugOnly for 'id'.
If no, then perhaps this whole loop should just be wrapped in #ifdef DEBUG.

(I tend to think the latter option -- #ifdef DEBUG -- is what we want.)

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Is this whole loop even useful in opt builds? (Does line 47 actually do
> anything, on its own?)
> If yes, we should use DebugOnly for 'id'.
> If no, then perhaps this whole loop should just be wrapped in #ifdef DEBUG.
> 
> (I tend to think the latter option -- #ifdef DEBUG -- is what we want.)

yeah, I'll ifdef that loop out.

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: ifdef out debug only code

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Thanks for catching this Daniel.

Comment 5

[Daniel Holbert [:dholbert] (AFK Aug 23-25)]

[needinfo=tbsaunde to make sure this gets landed]

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7aa4fec51e5