Closed Bug 108750 Opened 23 years ago Closed 23 years ago

split nsDOMCSSAttributeDeclaration into its own file

Categories

(Core :: CSS Parsing and Computation, defect, P3)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Whiteboard: [whitebox])

Attachments

(1 file)

We should split nsDOMCSSAttributeDeclaration into its own file for two reasons:
 1. bug 107101, reorganizing CSS into logical directory structure
 2. putting CSS back into layout

The patch I'm about to attach should be sufficient for both.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
OK, the deal here is that to reorganize CSS code to put
nsDOMCSSAttributeDeclaration into layout, we can't just create it using |new|. 
Since DOMCSSAttributeDeclaration, a common base class between
nsDOMCSSAttributeDeclaration and DOMCSSDeclarationImpl has all virtual methods
and is used directly in the DOMSlots, I couldn't really just cache the
nsIFactory using FindFactory and then CreateInstance off of it, so I created my
own little factory interface and class.  I called in the CSSOMFactory since I
suspect we may need to use it for some other CSSOM objects that will be
implemented in layout and created from content (e.g., nsDOMComputedStyle),
although I haven't actually checked whether I actually will need it for that.
The moved code (nsDOMCSSAttributeDeclaration code) has no modifications other
than the "glue" at the beginning and end of the file (license, |#includes|,
header guards, etc.).
sr=hyatt.
jrgm pointed out that nsDOMCSSAttributeDeclaration.cpp is 32 characters, one too
many for the poor Mac.

How about nsDOMCSSAttributeDecl.{h,cpp} ?
... or nsDOMCSSAttrDeclaration.{h,cpp}
nsDOMCSSAttrDeclaration.{h,cpp} sounds good to me.

r/sr=jst for the whole patch.
Fix checked in 2001-11-06 22:59/23:06 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [whitebox]
Blocks: 234923
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: