Closed
Bug 1087506
Opened 10 years ago
Closed 10 years ago
Add more keycode mappings to gonk
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
This adds support for Page Up/Page Down, Escape, and Volume Mute. Volume Up and Volume Down support will be added by bug 989198.
Attachment #8509698 -
Flags: review?(masayuki)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8509698 [details] [diff] [review] Add more keycode mappings to gonk Why don't you remove NS_VK_PAGE_UP and NS_VK_PAGE_DOWN for VOLUME_UP and VOLUME_DOWN? http://mxr.mozilla.org/mozilla-central/source/widget/gonk/GonkKeyMapping.h#51
|
Assignee | |
Comment 2•10 years ago
|
||
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1) > Why don't you remove NS_VK_PAGE_UP and NS_VK_PAGE_DOWN for VOLUME_UP and > VOLUME_DOWN? > http://mxr.mozilla.org/mozilla-central/source/widget/gonk/GonkKeyMapping.h#51 Bug 989198 does that. See patch 7.
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8509698 [details] [diff] [review] Add more keycode mappings to gonk Okay, thank you for your explanation.
Attachment #8509698 -
Flags: review?(masayuki) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d9aa26c87dbb
https://hg.mozilla.org/mozilla-central/rev/d9aa26c87dbb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•