Closed
Bug 1087549
Opened 10 years ago
Closed 10 years ago
IonScript::refcount_ is poorly named
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file, 1 obsolete file)
10.69 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
When reading the Ion frame invalidation code, I was misled by the name of IonScript::incref; I didn't expect that to be the operation that makes IonScript::invalidated() return true. This patch renames: - IonScript::refcount_ to invalidationCount_ - IonScript::refcount to invalidationCount - IonScript::incref to incrementInvalidationCount - IonScript::decref to decrementInvalidationCount - IonScript::offsetOfRefcount to offsetOfInvalidationCount
Attachment #8509727 -
Flags: review?(jdemooij)
Assignee | ||
Comment 1•10 years ago
|
||
Fixed dangerous typo.
Assignee: nobody → jimb
Attachment #8509727 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8509727 -
Flags: review?(jdemooij)
Attachment #8509730 -
Flags: review?(jdemooij)
Comment 2•10 years ago
|
||
Comment on attachment 8509730 [details] [diff] [review] Give IonScript::refcount_ and associated functions better names. Review of attachment 8509730 [details] [diff] [review]: ----------------------------------------------------------------- Much clearer, thanks!
Attachment #8509730 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a47eeab98b0
Flags: in-testsuite-
Target Milestone: --- → mozilla36
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a47eeab98b0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•