Closed
Bug 1087564
Opened 10 years ago
Closed 9 years ago
When entering DOM fullscreen, toolbars are still visible if browser.fullscreen.autohide is false
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: quicksaver, Unassigned)
References
Details
STR: 1. Go to about:config and disable browser.fullscreen.autohide 2. Go to https://www.humblebundle.com/ 3. Load up any game 4. When it's ready and playing, click its fullscreen button Results: the toolbars at the top are visible, even though they're completely inaccessible (or should be) while in DOM fullscreen (please correct me if I'm using the terminology wrong) like this. Another example is any YouTube video in fullscreen, you can't access the toolbars by moving the mouse up when the preference is enabled, so the toolbars shouldn't be visible either when the preference is disabled. This preference should really only be followed when in browser fullscreen mode, where the toolbars are still accessible but hidden away at the top until you move the mouse there. In DOM fullscreen mode, like in a game or video or anything else, the chrome should always be hidden, regardless of that preference. I'm opening this as UNCONFIRMED because I don't know if this is actually not intended behavior, I would appreciate it if someone could confirm this. (BTW I've only tested this on Windows, so I assume Linux will behave the same. Mac OS X browser fullscreen mode is a little different, as the toolbars never hide at all, so I'm not sure of what the behavior there should be, but I'm happy to test once someone confirms this is actually a bug.)
Comment 1•10 years ago
|
||
Reference ticket: https://github.com/Quicksaver/The-Fox--Only-Better/issues/75#issuecomment-60142486 i confirm this bug on linux.
Comment 2•10 years ago
|
||
Jared, do you know about how DOM fullscreen is meant to work in this case?
Flags: needinfo?(jaws)
Comment 3•10 years ago
|
||
This is indeed a bug in our autohide code. We shouldn't be showing the chrome in DOM fullscreen.
Component: Untriaged → Toolbars and Customization
Flags: needinfo?(jaws)
Comment 4•10 years ago
|
||
I guess we could stop using JS to hide toolbars for DOM fullscreen mode and instead use the inDOMFullscreen attribute to hide them with CSS (see bug 714675).
Comment 5•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > I guess we could stop using JS to hide toolbars for DOM fullscreen mode and > instead use the inDOMFullscreen attribute to hide them with CSS (see bug > 714675). Is there actually an existing reason the sliding animation isn't using CSS transitions rather than JS? Always been curious.
Looks like the issue is still presented on Release(39) but not on current DevEdition(41) and Nightly(42) I couldn't find the bug which fixed it, though.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•