Update email preference center copy & layout to accommodate Newsletters vs. Interests for One-off emails

RESOLVED FIXED

Status

www.mozilla.org
Newsletters
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jessilyn Davis (Maternity Leave), Assigned: kohei)

Tracking

Production
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1552280] , URL)

Attachments

(10 attachments, 5 obsolete attachments)

(Reporter)

Description

3 years ago
Created attachment 8509760 [details]
Email_Preference_Center_Redesign_Mockup.png

Things that are changing on this page:

* How certain "subscription" flags are now displayed in separate, but complimentary, section to "Firefox & You" and the new "Firefox OS" main newsletters. (all other newsletters can go below the new "Interests" section) See attached mockup.

* Copy to describe description flags, and the new Interest categories
Copy to be finalized this week. Draft copy in progress: https://docs.google.com/a/mozilla.com/document/d/1qqoq5p1_g7v81c5GpqTh3acHoLym6Rfio9j0lNPq47E/edit#


Needs:
* Front-end design (minimal - please see attached mockup)

* Front-end coding of new design
 - Checkboxes for Interests section
 - Special way to call out Interests section (in mockup currently achieved with line break and section indention)
 - Localization into our 8 newsletter languages (in addition to EN): ES, PT-BR, DE, FR, ID, RU, PL, HU


For Localization, some newsletter l10n teams have SVN access and might be up for the quick challenge. Some newsletter l10n teams are not integrated with websites l10n, but may be up for the quick challenge of localize the page content in a separate workflow (ie spreadsheet with 2 col: Col A = EN, Col B = l10n) if that helps workload. NOTE: We don't need this page in every locale that Firefox supports (since we don't send the newsletter in every language that Firefox supports).


Things that may not need changing on this page:
- back-end basket functionality
-- TBD if basket's current infra can work with the Interests hard-coded into the design (vs. having full capability to reorder and assign which "FLGS" are Interests). Whichever way is the easiest way forward to meet the deadline = awesome.


Ideal launch date:
Nov 6

Drop dead launch date:
Nov 17 (in time for Nov 18th EN newsletter send)


Please let me know if you have any questions. Thank you.
(Reporter)

Updated

3 years ago
Blocks: 1062523
Hey Mike and John-

I'm going to put time on the calendar for us to discuss with Jess to see if Nov 17 is realistic at this point.

Thx,
Jen
Whiteboard: [kb=1552280]

Updated

3 years ago
Assignee: nobody → kohei.yoshino
(Assignee)

Comment 2

3 years ago
Created attachment 8513867 [details]
Screenshot: the current preference center

Comment 3

3 years ago
We have some draft copy for the new email preference center. 

MJ Kelly, can you take a look and work some magic? 

 https://docs.google.com/a/mozilla.com/document/d/1qqoq5p1_g7v81c5GpqTh3acHoLym6Rfio9j0lNPq47E/edit?usp=sharing
Flags: needinfo?(mjkelly)
Notes from mtg today:

No new designs needed.

Jess say no Basket work needed
Ben circle back with pmac to see if there are any Basket blockers 

Jess and Ben will change endpoint signups

Comment 5

3 years ago
(In reply to Ben Niolet from comment #3)
> We have some draft copy for the new email preference center. 
> 
> MJ Kelly, can you take a look and work some magic? 
> 
>  https://docs.google.com/a/mozilla.com/document/d/
> 1qqoq5p1_g7v81c5GpqTh3acHoLym6Rfio9j0lNPq47E/edit?usp=sharing

Ben, I made some copy changes. Let me know what you think.
Flags: needinfo?(mjkelly)
(Reporter)

Comment 6

3 years ago
Thanks MJ. Ben and I like the changes.

Matej, can you read over real quick and let us know if there are any edits/flags as soon as possible? (Want to finalize and get to l10n quickly.)

https://docs.google.com/a/mozilla.com/document/d/1qqoq5p1_g7v81c5GpqTh3acHoLym6Rfio9j0lNPq47E/edit#
Flags: needinfo?(Mnovak)

Comment 7

3 years ago
Made a few edits and left some comments. Let me know if you have any questions.

Thanks.
Flags: needinfo?(Mnovak)
(Reporter)

Comment 8

3 years ago
Perfect - thanks, Matej!

Kohei - the Email Preference Center copy is ready:

https://docs.google.com/a/mozilla.com/document/d/1qqoq5p1_g7v81c5GpqTh3acHoLym6Rfio9j0lNPq47E/edit#

Please let us know if you have any questions about the design mockup and copy there. Please also let us know when/where it's somewhere to check out :D


The goal is for this page to go live on Nov 17th in EN, ES, PT-BR, DE, FR, ID, RU, PL, HU


Pascal & Flod - I KNOW this is 100% short timeline and 10th anniversary l10n is definitely the priority! Please advise on the best way to approach the l10n aspect of this project. I can ask the newsletter teams to help localize the content in a gdoc spreadsheet if that's helpful; granted those teams that do not have SVN access/knowledge may need help from the l10n teams to get the translated strings into the correct files.
We'll need to wait for the PR to extract strings, but it seems that there are quite a few new strings in the doc.

To be honest I don't think we'll get localizations for November 17, note that I won't be able to work on it before November 11. Even if we get localization from outside, it still needs to be reviewed by mozilla.org localizers for consistency.

Is there a specific reason behind the choice of date (Nov 17)?
(Reporter)

Comment 10

3 years ago
(In reply to Francesco Lodolo [:flod] from comment #9)

Thank you, Flod.

> We'll need to wait for the PR to extract strings, but it seems that there
> are quite a few new strings in the doc.

There are 25 new strings.

> 
> To be honest I don't think we'll get localizations for November 17, note
> that I won't be able to work on it before November 11. Even if we get
> localization from outside, it still needs to be reviewed by mozilla.org
> localizers for consistency.

Definitely understand not working on it until Nov 11th. If it sounds like a good plan, I can get our newsletter localization teams to get the strings localized by the 11th so that your team can review and insert by the 17th? Would that be possible?


> 
> Is there a specific reason behind the choice of date (Nov 17)?

There is - we paused Firefox & You sending to refactor & redesign of our entire newsletter program and the first newsletter using the new everything is the November newsletter, scheduled to launch Nov 18. 

The content of our newsletters and the backend mechanics of the newsletter (signup forms, email preference center, and updating of current subscriber subscription data) are all changing to support the scale our our newsletter programs (multiple languages + multiple products).

The best time to make this switch is before we send our next newsletter. Since we've been paused, the traffic to our email preference center has been low and it's a great time to make all these switches before "Firefox & You" branded emails start going out again (the 10th anniversary one-off emails are general "Firefox" branded.)
 

More info here if you're interested:

https://docs.google.com/a/mozilla.com/presentation/d/1SOZb6Jg7fFWOggwF76UpGKwXWEgdnQhTdO_GYxy_tVc/edit#slide=id.g3ebced12b_07


There is a fall back plan if we can't get all the moving pieces together by Nov 17th - however, it looks like everything will come together by then. (And it will be great to go live before I'm out on maternity leave.)
(Assignee)

Comment 11

3 years ago
I sent requests to access these docs.
(Reporter)

Comment 12

3 years ago
Ah! I apologize Kohei! Access opened :)
(Assignee)

Comment 13

3 years ago
Thanks :jdavis, I've got invitations :)
(In reply to Jessilyn Davis from comment #10)
> Definitely understand not working on it until Nov 11th. If it sounds like a
> good plan, I can get our newsletter localization teams to get the strings
> localized by the 11th so that your team can review and insert by the 17th?
> Would that be possible?

ES, PT-BR, DE, FR, ID, RU, PL, HU. 

Can you send me and Pascal an email with the names of localizers you work with for newsletter? For some teams we'll have overlaps, but not all of them, so I want to make ask localizers if they think this is needed or prefer to work directly on the strings.

GoogleDocs is bad and evil, we should use a simple .txt file with the same format that will be used on SVN. We also need the exact string that will be used in the HTML template. Just to give an example, in the current page "Manage your Newsletter Subscriptions" is actually "Manage your <span>Newsletter Subscriptions</span>".

@pascal
I'm not familiar with the newsletter bits, but it looks like we're exposing strings for all locales through newsletter.lang, and the page is enabled only for the actual newsletter locales.
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/locales/es-ES/newsletter/

Does it make sense to start separating these strings in a different lang file? Or should we enable the preference center for more locales, even if the actual newsletter will be in a different language (and add some sort of warning)?
Flags: needinfo?(pascalc)
(Reporter)

Comment 15

3 years ago
(In reply to Francesco Lodolo [:flod] from comment #14)

> Can you send me and Pascal an email with the names of localizers you work
> with for newsletter?

Email is in your inboxes.

> 
> GoogleDocs is bad and evil, we should use a simple .txt file with the same
> format that will be used on SVN. We also need the exact string that will be
> used in the HTML template. Just to give an example, in the current page
> "Manage your Newsletter Subscriptions" is actually "Manage your
> <span>Newsletter Subscriptions</span>".


Totally understand. Could you attach an example of what the .txt file should look like for this page at present?
(In reply to Jessilyn Davis from comment #15)
> Totally understand. Could you attach an example of what the .txt file should
> look like for this page at present?

Structure is very simple. 

Basically original string starts with ";", translation goes on the next line. 
http://svn.mozilla.org/projects/mozilla.com/trunk/locales/es-ES/download_button.lang

Even if we create a file with only those strings, it would be easy to extract strings and move them where necessary (we have tools to work with these files).
(In reply to Francesco Lodolo [:flod] from comment #14)
> (In reply to Jessilyn Davis from comment #10)
> > Definitely understand not working on it until Nov 11th. If it sounds like a
> > good plan, I can get our newsletter localization teams to get the strings
> > localized by the 11th so that your team can review and insert by the 17th?
> > Would that be possible?
> 
> ES, PT-BR, DE, FR, ID, RU, PL, HU. 
> 
> Can you send me and Pascal an email with the names of localizers you work
> with for newsletter? For some teams we'll have overlaps, but not all of
> them, so I want to make ask localizers if they think this is needed or
> prefer to work directly on the strings.
> 
> GoogleDocs is bad and evil, we should use a simple .txt file with the same
> format that will be used on SVN. We also need the exact string that will be
> used in the HTML template. Just to give an example, in the current page
> "Manage your Newsletter Subscriptions" is actually "Manage your
> <span>Newsletter Subscriptions</span>".
> 
> @pascal
> I'm not familiar with the newsletter bits, but it looks like we're exposing
> strings for all locales through newsletter.lang, and the page is enabled
> only for the actual newsletter locales.

Yes, the reason is that initially, subscription to the newsletter was via the footer of all pages pn the PHP site.

> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/locales/es-ES/
> newsletter/
> 
> Does it make sense to start separating these strings in a different lang
> file? Or should we enable the preference center for more locales, even if
> the actual newsletter will be in a different language (and add some sort of
> warning)?

I think we should still enable the preference center only for the locales that translate the newsletter, if you can read a newsletter in English, you can subscribe to it via a page in English, the reverse situation is less true. I see value in keeping some of the strings in newsletter.lang because of the subscription forms we put here and there on the site, but we could start moving the preference center strings to their own file.
Flags: needinfo?(pascalc)
(Reporter)

Comment 18

3 years ago
Hello Kohei!

I just wanted to check in on this - how's the coding process going with the new layout + copy? Do you have an ETA for when this will be available on a dev server to test?

Thanks!

Jess
(Assignee)

Comment 19

3 years ago
Hi, I'm going to work on this today and maybe tomorrow. Should be ready for test this week!
(Reporter)

Comment 20

3 years ago
Thanks Kohei!

Update on timing/l10n: Given the scope of work to be done on the other 2 moving parts to this project (basket/signup forms - Bug 1093185 & fixing of historical data - Bug 1093687, both of which have to be done before the email preference center can go live) here's the plan for the email preference center:


This week: Test functionality and design, get it ready for launch, l10n begins

--- Nov newsletter launches Nov 18th, will NOT update the email preference center until after that send ---

Dec 1 or Dec 2 - l10n is complete, and page is made live in ES, PT-BR, DE, FR, ID, RU, PL, HU in time for Dec newsletter send.


Does this sound like a good plan? Any questions/comments/concerns?

Thanks everyone for your help on this.
Depends on: 1093185, 1093687
Not sure if those dates work in December, considering that we're in Portland and I'm not sure how much work we'll be able to get done there.

Side note, considering that a lot of resources are probably shared: we still owe about 25 localization teams a contribute page.
(Reporter)

Comment 22

3 years ago
Actually - given the Portland work week the first week in Dec, should this page have a goal live date of Dec 8?

We just need it live by Dec 9th in time for the December Newsletter. 

Please advise on timing.
December 8 sounds good to me in terms of l10n (I'll be back home on Dec 7). The most important part is to set up string files, and that I can do as soon as Kohei is ready with templates.
(Assignee)

Comment 24

3 years ago
Created attachment 8521673 [details]
Screenshot including proposed copy

Here's a screenshot including the proposed copy. Since the newsletter listing and descriptions are managed by Basket, these updates are not included.

Code: https://github.com/kyoshino/bedrock/compare/bug-1087579-newsletter-prefs

A few questions:

I think a mix of radios and checkboxes for the subscription choices may  confuse users (and the code). Could we decide between the two? My code/screenshot simply uses checkboxes.

When would the Marketplace have 3 platform choices? These are nested in the proposal, so the code needs a tweak for that.
(Assignee)

Updated

3 years ago
Flags: needinfo?(jdavis)
(Reporter)

Comment 25

3 years ago
Thanks Kohei! Can you show a mockup of the page? (I can read code, but won't know about how to make the call until I can see it in action).
Flags: needinfo?(jdavis) → needinfo?(kohei.yoshino)
(Reporter)

Comment 26

3 years ago
blarg - i went to the github link - not the attachment. Looking now! Thanks!
Flags: needinfo?(kohei.yoshino)
(Reporter)

Comment 27

3 years ago
Hello Kohei!

Thank you so much for taking the first stab at coding this! I've just updated dev basket & the dev email preference center with the updated content in hopes of helping my feedback be a bit clearer. 

Example subscriber on dev:
https://www-dev.allizom.org/en-US/newsletter/existing/b8d4f008-ae3b-45e1-b8f6-4cee59bedb5c/


I'm cc'ing pmac on here as he may have suggestions on how to best hard-code the newsletter vs. interests fields on the email preference center page. (In the future, we'll add in basket functionality to have a way to determine if an item is a "newsletter" vs. "interest" on the email preference center page. For now, some hard-coding will have to take effect.)


Here are my edits:

* Radio buttons are important to show the user explicitly the "subscribe" vs. "unsubscribe" option for newsletters. I'd like to keep these in for the "Newsletters" section.

* The interests should be set apart differently than the other newsletters so that the user understands that this isn't a newsletter "subscription" so much as a particular interest field. I think this is best achieved with a checkbox and might look more in place after the following edits.

* Add in some sort of thicker line/divider to set a part the "Interests" section. This section starts with the "Getting too much email from us?" title. This title should be the same font size as "Newsletters"

* Change "Subscribe" in the Interests section to "I’m interested in:"

* Instead of the current "Firefox Marketplace for Desktop", "Firefox Marketplace for Firefox OS", "Firefox Marketplace for Android" lines on the dev email preference center, these should all be nested under the "Firefox Marketplace" title with the blurb of "Know when the coolest apps hit the Marketplace for your platform:" then just a bulleted list of "Desktop", "Android", "Firefox OS" (I'll update these user-facing titles in dev basket when the new design is there. I just wanted to be able to see easily the difference between the "Firefox for desktop" interest vs. "Firefox Marketplace for Desktop" as we're working through the layout.)


More helpful pieces:

* Check out this doc that explains the newsletters vs. interests and their front-end and back-end configurations:

https://docs.google.com/a/mozilla.com/spreadsheets/d/1xtOKfA10-a0yeoxc9uwkDZ9iXY2zRwR9_MLDav14yFs/edit


* In basket dev, I've ordered the newsletter items as follows: 
* Items 1-8 = Active newsletters that could show in the email preference center. 
* Items 30-40 = Old newsletters that shouldn't show for folks. (We'll probably delete at some point in the not-so-distant-future.)
* Items 50+ are the interest areas.


Please let me know if you have any questions and keep us posted on when the next coding mockup will be ready. Ideally, we'll get the updated design on a dev server to unlock the l10n process as soon as possible.

Thanks!
(Reporter)

Comment 28

3 years ago
Hey Kohei!

I just wanted to see if you'd have time to work some code magic this weekend? In order to make our l10n deadlines, we need to get this coded and in a good place on dev by Monday/Tuesday.

Thanks!

Jess
Flags: needinfo?(kohei.yoshino)
(Assignee)

Comment 29

3 years ago
Sorry, I have missed your last comment. Yes, I can work on this tomorrow.
Flags: needinfo?(kohei.yoshino)
(Assignee)

Comment 30

3 years ago
Created attachment 8527403 [details]
Screenshot reflecting feedback

Here's a screenshot of the page reflecting Jessilyn's feedback, checkboxes for the interests, nested marketplace options, etc. Does this work for you?
Attachment #8521673 - Attachment is obsolete: true
Flags: needinfo?(jdavis)
(Reporter)

Comment 31

3 years ago
Kohei - this is looking great! I love the layout, radio buttons, checkboxes, and nesting of the Marketplace interests.

The only last edit is making sure that these are the only fields that show for the "I'm interested in" section (these are the names of the newsletter IDs):

firefox-desktop
mobile
os
mozilla-general
marketplace-desktop
marketplace-android
marketplace
firefox-os



All the other fields should show per the basket settings under the "Newsletters" section:

mozilla-and-you
firefox-os-news
about-mozilla
ambassadors
affiliates
app-dev
mozilla-phone
get-involved


You may have to hard-code these newsletter ids to the right sections as basket's admin is not set up to automatically determine which id is a "newsletter" vs. an "interest".

Please let me know if this makes sense.

Thanks!
Flags: needinfo?(jdavis)
(Reporter)

Comment 32

3 years ago
Hey Kohei, I wanted to check in on timing and your schedule. Do you have time to work on this this evening to get the code on dev by tomorrow by chance? 

We need to get the page coded and ready by end of day tomorrow for Flod and Pascal to activate the l10n pieces in time for the Dec 8th launch.

If you can't tackle it, please have no worries - we'll just need to tag in Pmac to help get us across the finish line.

Thank you for all your hard work on this!
(Assignee)

Comment 33

3 years ago
Ahh, I'll check for newsletter vs interest. Will send a pull request shortly.
(Assignee)

Comment 34

3 years ago
Created attachment 8527903 [details]
Screenshot: newsletter vs interests
Attachment #8527403 - Attachment is obsolete: true
(Assignee)

Comment 35

3 years ago
Created attachment 8527905 [details] [review]
pull request
(Reporter)

Comment 36

3 years ago
Sweet! Thanks Kohei! We're almost there. The problem I think is I only listed the newsletters that are currently live, but basket is set to show any/all newsletter subscriptions that you're subscribed to, even if the newsletter isn't live (ie Beta news, Firefox Flicks, & Firefox Tips)

Would it be possible to make sure that ONLY these interests show up in the "I'm interested in" section:

firefox-desktop
mobile
os
mozilla-general
marketplace-desktop
marketplace-android
marketplace
firefox-os


Then any/all other newsletters that show up (due to basket's admin settings), show up in the Newsletter section in the order in which it appears in basket?



Also, is it possible to pull the data from basket dev instead of basket prod? Dev has all the latest newsletters + interests and their updated descriptions. (Prod does not yet as we're not ready to change the strings there until the l10n and new design are in place.)
(Assignee)

Comment 37

3 years ago
(In reply to Jessilyn Davis from comment #36)
> Would it be possible to make sure that ONLY these interests show up in the
> "I'm interested in" section:
> 
> firefox-desktop
> mobile
> os
> mozilla-general
> marketplace-desktop
> marketplace-android
> marketplace
> firefox-os
> 
> 
> Then any/all other newsletters that show up (due to basket's admin
> settings), show up in the Newsletter section in the order in which it
> appears in basket?

I see. Will remove Beta, Flicks, etc.

> Also, is it possible to pull the data from basket dev instead of basket
> prod? Dev has all the latest newsletters + interests and their updated
> descriptions. (Prod does not yet as we're not ready to change the strings
> there until the l10n and new design are in place.)

I'll check the URL setting.
(In reply to Kohei Yoshino [:kohei] from comment #37)
> (In reply to Jessilyn Davis from comment #36)
> > Also, is it possible to pull the data from basket dev instead of basket
> > prod? Dev has all the latest newsletters + interests and their updated
> > descriptions. (Prod does not yet as we're not ready to change the strings
> > there until the l10n and new design are in place.)
> 
> I'll check the URL setting.

bedrock dev uses basket dev, bedrock stage -> basket stage, etc.
(Assignee)

Comment 39

3 years ago
Created attachment 8527950 [details]
Screenshot: all active newsletters

I've just found a filter in the current code:
https://github.com/mozilla/bedrock/blob/master/bedrock/newsletter/views.py#L166-L168

If I change this to show all active newsletters, the page looks like the attached screenshot.

Jessilyn: Do you want to show all newsletters like this screenshot regardless of the user's subscription status, using the "active" flag instead of the "show" flag? If so, the Mozillians newsletter should probably be treated as an exception, because it's only for vouched Mozillians.

(In reply to Paul McLanahan [:pmac] from comment #38)
> bedrock dev uses basket dev, bedrock stage -> basket stage, etc.

Thanks for the info, so I don't have to configure the URL.
Flags: needinfo?(jdavis)
Created attachment 8528199 [details]
test_l10n.png

Checked the PR and I'm counting only 10 new strings. I plan to add them to newsletter/existing.lang, since we already have that file in SVN for the involved locales and it's currently used only to enable the template.

Having said that, I checked the page locally and I'm seeing several newsletter title+description in English. Is that expected?

See screenshots: strings starting with * are new strings, string marked in yellow are not currently localized. Should they be?
(In reply to Francesco Lodolo [:flod] from comment #40)
> See screenshots: strings starting with * are new strings, string marked in
> yellow are not currently localized. Should they be?

If we need to localize them, from my tests they need to be in newsletter.lang, at that point I'll add all the strings to that file.
(Reporter)

Comment 42

3 years ago
(In reply to Kohei Yoshino [:kohei] from comment #39)

> Jessilyn: Do you want to show all newsletters like this screenshot
> regardless of the user's subscription status, using the "active" flag
> instead of the "show" flag? If so, the Mozillians newsletter should probably
> be treated as an exception, because it's only for vouched Mozillians.

Hey Kohei!  We should only show the newsletters that have the "show" flag. This is exactly why we don't "show" the Mozillians email list :) (It only appears if you are subscribed to it via being vouched on mozillians.org - you can't opt-into it otherwise.)

The "active" toggle is a bit of just an internal admin indicator at the moment and doesn't have an effect on the page. This might be configured in the future to designate if the flag should be shown at all in the email preference center, even if the person is subscribed so that we can keep the email preference center clean.


2 other edits:

1) "Mozilla" is actually an interest (currently listed in the email pref center as a newsletter) and I've added the description to basket dev:

ID = ‘mozilla-general’
“Special announcements and messages from the team dedicated to keeping the Web free and open.”


2) “Firefox OS smartphone owner?” is also an interest
ID = firefox-os
Description: Don’t miss important news and updates about your Firefox OS device.




For l10n, once I see the final email preference center on dev, I'll take a screenshot and highlight the strings that need to be localized (that have either changed since their original l10n, or are brand new to the page) - sound good?

Thanks!
Flags: needinfo?(jdavis)
(Assignee)

Comment 43

3 years ago
(In reply to Jessilyn Davis from comment #42)
> The "active" toggle is a bit of just an internal admin indicator at the
> moment and doesn't have an effect on the page. This might be configured in
> the future to designate if the flag should be shown at all in the email
> preference center, even if the person is subscribed so that we can keep the
> email preference center clean.

I'm thinking how to hide inactive newsletters like Beta, Flicks, etc. Can I use it now so we don't have to hardcode these IDs in the code?

> 2 other edits:
> 
> 1) "Mozilla" is actually an interest (currently listed in the email pref
> center as a newsletter) and I've added the description to basket dev:
> 
> ID = ‘mozilla-general’
> “Special announcements and messages from the team dedicated to keeping the
> Web free and open.”

I cannot find "mozilla-general". The current undescribed Mozilla newsletter is "mozilla".

> 2) “Firefox OS smartphone owner?” is also an interest
> ID = firefox-os
> Description: Don’t miss important news and updates about your Firefox OS
> device.

"Firefox OS smartphone owner?" ("firefox-os") doesn't the "active" flag. Can you activate that?
(Assignee)

Comment 44

3 years ago
(In reply to Kohei Yoshino [:kohei] from comment #43)
> "Firefox OS smartphone owner?" ("firefox-os") doesn't the "active" flag. Can
> you activate that?

Correct: "firefox-os" doesn't have "active" nor "show" flag
(Reporter)

Comment 45

3 years ago
(In reply to Kohei Yoshino [:kohei] from comment #43)
> (In reply to Jessilyn Davis from comment #42)

> I'm thinking how to hide inactive newsletters like Beta, Flicks, etc. Can I
> use it now so we don't have to hardcode these IDs in the code?

Sounds great! Please only use 'active' newsletters in the active section:

mozilla-and-you
firefox-os-news
about-mozilla
ambassadors
affiliates
app-dev
mozilla-phone
get-involved




> > 2 other edits:
> > 
> > 1) "Mozilla" is actually an interest (currently listed in the email pref
> > center as a newsletter) and I've added the description to basket dev:
> > 
> > ID = ‘mozilla-general’
> > “Special announcements and messages from the team dedicated to keeping the
> > Web free and open.”
> 
> I cannot find "mozilla-general". The current undescribed Mozilla newsletter
> is "mozilla".

Please make sure you're using the dev instance of the email preference center that uses the dev instance of basket - ie:

https://www-dev.allizom.org/en-US/newsletter/existing/520c5c53-9931-4a16-94ac-481f9026cf98



> 
> > 2) “Firefox OS smartphone owner?” is also an interest
> > ID = firefox-os
> > Description: Don’t miss important news and updates about your Firefox OS
> > device.
> 
> "Firefox OS smartphone owner?" ("firefox-os") doesn't the "active" flag. Can
> you activate that?

Same comment as above - please double check that you're using the basket dev instance.
(Assignee)

Comment 46

3 years ago
Created attachment 8528500 [details]
Screenshot: dev

Thanks! I had to set the dev instance URL in the local settings anyway...

Subscribed the Firefox & You newsletter and finally got this!
Attachment #8527903 - Attachment is obsolete: true
Attachment #8527950 - Attachment is obsolete: true
(Reporter)

Comment 47

3 years ago
Brilliant!

Then all we have to do is confirm that if you were subscribed to any of the other active newsletters (that are not set to 'show') - that you *will* see them in the newsletter section:


mozilla-and-you
firefox-os-news
about-mozilla
ambassadors
affiliates
app-dev
mozilla-phone
get-involved


So if you were subscribed to everything/super active Mozillian, you would see up to 8 newsletters listed under the "Newsletters" section.

Make sense?

Thanks Kohei!
Note: I'll need someone to explain step-by-step which strings to extract, and how to test the page locally.
Because at this point I have no idea how this page works besides the strings actually in the template file.
(Assignee)

Comment 49

3 years ago
Created attachment 8528513 [details]
Screenshot: dev, all newsletters

For testing, if I remove the check for the 'show' and subscription, 8 newsletters are displayed like this screenshot. So it's working well.
(Assignee)

Comment 50

3 years ago
Created attachment 8528522 [details]
newsletters.additions.lang

:flod, I think there is no way to "extract" newsletter names and descriptions. So those have to be written in newsletter.lang directly, I guess. Here is a list of additional strings I have collected. Does this work?
Flags: needinfo?(francesco.lodolo)
We can just add them to a template comment at the end of the file for ease of extraction. The other option I was considering is to just have all the strings in a dict (keyed on newsletter slug) in the view or template, and use those directly instead of what comes from the API. Would make l10n a lot less confusing if it were done via our normal workflow.
@kohei
It definitely helps. Almost identical to my WIP, but I missed the new description of Firefox & You.

If we could have them all in existing, it would be great.
That way we could stop asking all 90 locales to translate them, and add the string to newsletter/existing.lang
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 53

3 years ago
Yeah, I totally agree that the l10n process could be better here, in some way...
(In reply to Francesco Lodolo [:flod] from comment #52)
> That way we could stop asking all 90 locales to translate them, and add the
> string to newsletter/existing.lang

Would also be useful to know if these strings are used anywhere else outside of the pref center.

Anyhow, I have a local version of newsletter.lang (it's +27 strings) in case we need to move this forward quickly. As said the issue I have with this is that we're asking 90 locales to localize strings actually used by only 6 of them.
(Assignee)

Comment 55

3 years ago
Please proceed with your local newsletter.lang as the deadline on December 8 is approaching... I'm sorry for my late work!!
I pushed out the strings, status for this page is here
https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=newsletter.lang

At this point we should try not to change or add more strings.
@Kohei
You should be also able to use German for testing, since it's already translated.
(Assignee)

Comment 58

3 years ago
Created attachment 8529018 [details]
Screenshot: de locale, all newsletters displayed

Thanks :flod, here's a screenshot of the German localized page.
(Reporter)

Comment 59

3 years ago
This is beautiful! Thank you Kohei and Flod!  The EN and DE versions look fantastic. I'm so excited to see this go live on Dec 8.

Flod re: " As said the issue I have with this is that we're asking 90 locales to localize strings actually used by only 6 of them."

I'm only asking for the email preference center to be only in these 9 languages:

EN
ES
PT
DE
FR
ID
RU
PL
HU

No need for all 90 teams to localize. I actually prefer it if all 90 teams don't! The reason: I think it's a better experience if it's not localized in all 90 so that there isn't any confusion as to why someone who uses the JA build of Firefox, gets the newsletter in EN (or in one of the other languages), and then goes to visit the email preference center and it's in JA. We hard-code the email preference center links to include the locale in the newsletter so we avoid any issues with Firefox build + Language. 

I hope this helps alleviate any extra pressure/work from this funky l10n flow (which I agree we should figure out a better way to do this in the future. The good thing is - I think/hope we won't have to change this page for a long time yet.)


Thanks again team!
(Reporter)

Comment 60

3 years ago
Hey team, as I'm heading out on maternity leave today, Ben Niolet will be managing the launch of this on Dec 8th. 

Ben, please check in on the bug and be sure to test the functionality on dev and the 9 newsletter languages before this goes live. (I'm cc'ing Rbillings in case she can help spot check too.)

Things to look for:

1) The subscription flags match the right Y FLGS in ExactTarget (Master_Subscribers).

2) Once you change the subscription flags (and language & email format) on the email preference center, they are updated in Master_Subscribers - and when you revisit the page, the updated (subscription flags and email settings) display.

3) The globally unsubscribe function works for all the FLGS on the page (ie everything gets changed to N in Master_Subscribers).

4) The "show" function is kept in tact so that newsletters that are NOT marked to "show" should NOT show up in the email preference center (ie "Mozillians" - which is an internal email program that folks should not be able to opt-in from the email preference center - you can only opt-in via mozillians.org).


Thank you all for your hard work on this! I'm excited to see it in action.
(In reply to Jessilyn Davis from comment #59)
> Flod re: " As said the issue I have with this is that we're asking 90
> locales to localize strings actually used by only 6 of them."

I know, that's a technical limitation on our side. We put these strings in a file shared across all pages called newsletter.lang, but most of it is used only by 8 of them. That's something that we'll need to fix (again, on our side). 

> No need for all 90 teams to localize. I actually prefer it if all 90 teams
> don't! The reason: I think it's a better experience if it's not localized in
> all 90 so that there isn't any confusion as to why someone who uses the JA
> build of Firefox, gets the newsletter in EN (or in one of the other
> languages), and then goes to visit the email preference center and it's in
> JA. We hard-code the email preference center links to include the locale in
> the newsletter so we avoid any issues with Firefox build + Language. 

There's no risk for that. The newsletter page is enabled only for those 8 locales ;-)
(Reporter)

Comment 62

3 years ago
Sweet - thanks, Flod :)
Update on the translation status: we're still missing hu and pl. I pinged both teams but I don't think we'll get the localization before the end of the day: Gabor from Hungarian missed the file on the webdashboard, Polish is still struggling with web content at the moment.

Pushing out localizations is definitely faster than pushing out bedrock updates, it's your call to decide if you're ready to move to production or not.

Comment 64

3 years ago
DEG is finishing up the ExactTarget cleanup today. Let's wait for their work to be done before we push to prod. That should let us go early tomorrow. 

As for PL and HU, if we go without, what will subscribers in those languages see when they hit the preference center page? If they see the old page, I'm concerned that we'll be sending the wrong flags to ET for those languages.
They should see the new page with some strings (the new ones) in English.

Comment 66

3 years ago
I think I can live with that, if we think it's going to be a quick turnaround on the l10n. Ideally, they'd all be perfect, but the reality is, those locales only pick up 600 or so subscribers a month. Not perfect, but I hate to hold this up further.
I hope to have both locales done at the beginning of this week, so I agree that we should just push the changes out.
(Assignee)

Comment 68

3 years ago
Asked a review in my pull request. Should be live today.

Comment 69

3 years ago
+1 Flod

Comment 70

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/435712e4b100f9b6fd9767adcd7957f6c91c5ca5
Fix Bug 1087579 - Update email preference center copy & layout to accommodate Newsletters vs. Interests for One-off emails

https://github.com/mozilla/bedrock/commit/38628e9a2e6bdd63757bd8c3b2ae135d95c4ac84
Merge pull request #2536 from kyoshino/bug-1087579-newsletter-prefs

Fix Bug 1087579 - Update email preference center copy & layout to accommodate Newsletters vs. Interests for One-off emails

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 71

3 years ago
Hi guys. Not sure if I missed a change or not since Jess was handling this right up until she left. But the current new page lists the Mozilla General flag as a newsletter. I believe this should actually be an interest down in the bottom section. 

I've been going through the history in the bug and while I see the German version had it the way it is today, I think Jess' intention all along was to have Mozilla as an interest, not a newsletter. Can someone let me know if I missed something on this?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 72

3 years ago
This sheet shows the layout as we intended: with two newsletters up top and the rest of the flags in teh bottom section for interests: 

https://docs.google.com/spreadsheets/d/1xtOKfA10-a0yeoxc9uwkDZ9iXY2zRwR9_MLDav14yFs/edit?usp=sharing

Comment 73

3 years ago
Created attachment 8533750 [details]
Pref center changes image

Hi guys. See issues with the preference center in this screenshot. Mozilla should be an interest flag and the Firefox owner interest is not a subset of the marketplace flag.

Comment 74

3 years ago
Hi Mike. Please note some bugs I'm seeing in the new pref center.
Flags: needinfo?(malexis)

Comment 75

3 years ago
You can see that page live at: 

https://www.mozilla.org/es-ES/newsletter/existing/01467f28-b2e1-4107-a03e-87a5e2e0c499
(Assignee)

Comment 76

3 years ago
I thought everything was correct on the dev server; will check it out soon.
Flags: needinfo?(kohei.yoshino)

Comment 77

3 years ago
Kohei, 

I just realized I didn't have all the interests active on basket. That's fixed now. Let's give it a minute to see if it "fixes" itself.
Flags: needinfo?(malexis)
(Assignee)

Comment 78

3 years ago
Thanks! One more issue is the basket slug of the Mozilla newsletter (Special announcements and messages...) is not "mozilla-general" but "mozilla", that's why it's shown not in the interest section but in the newsletter list. It should be "mozilla-general", or I can update the code to use "mozilla":

https://github.com/mozilla/bedrock/blob/master/bedrock/settings/newsletters.py#L61
Flags: needinfo?(kohei.yoshino)

Comment 79

3 years ago
Created attachment 8533801 [details]
emailpref2.png

Here's the current look. As I suspected, turning on all interest flags in basket fixed the indent on the Firefox OS owner. So based on my first round of testing, everything is great EXCEPT the Mozilla flag, which should be in the bottom section as indicated.
Attachment #8533750 - Attachment is obsolete: true

Comment 80

3 years ago
Let's keep "mozilla-general." I'm not sure of all the potential consequences for ET and basket if we change it to Mozilla now. 

It was tested on staging and dev with mozilla-general so I'm feeling more confident about that one.
(Assignee)

Comment 81

3 years ago
Yes, it was "mozilla-general" on dev but is "mozilla" on production. Ben, can you change the slug on Basket? Then all set.

Comment 82

3 years ago
Boom. Done. Sorry. Didn't catch that the discrepancy was on my end. I just hit "save" in Basket prod. Seems to take about 15 mins for changes to go from basket to the page, so we'll keep an eye on it. Thanks, Kohei!!!
(Assignee)

Comment 83

3 years ago
Created attachment 8534022 [details]
Screenshot: production

LGTM
(Assignee)

Comment 84

3 years ago
\o/
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Thanks for your help, Kohei!
Hi Ben-

Question:  Is there a use case of someone to go to the preference center w/out their ID in the query string?

Do we need this page?   http://www.mozilla.org/newsletter   Because I'm still seeing the old version.

Ping me on IRC if this doesn't make sense!

Thx,
Jen
Flags: needinfo?(bniolet)
Hi Jenn. Not sure what you mean. The page you linked to (/newsletter) is simply a page dedicated to signing up for the Firefox & You newsletter. The page this bug was modifying was /newsletter/existing/{TOKEN}/. If you go to that page without the {TOKEN} bit then you go to /newsletter/recovery/ which will let you enter your email and will email that address a link to the /existing/ page with the correct TOKEN for that email.
Flags: needinfo?(bniolet)

Comment 88

3 years ago
+1 to pmac. The /newsletter page is the signup page. We modified the unique page that displays when someone wants to update their email preferences.
You need to log in before you can comment on or make changes to this bug.