bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Multiple review? flags may be set on an attachment

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

(Assignee)

Description

4 years ago
In bug 1083954, we saw Review Board create multiple review? flags on a single attachment. There's a bug in here that needs reproduced and fixed.
(Assignee)

Comment 1

4 years ago
I'm able to reproduce this in tests:

review? sticks around when 1 person grants review

  $ exportbzauth author@example.com password
  $ bugzilla create-bug TestProduct TestComponent 'More Multiple Reviewers'

  $ hg up -r 0 > /dev/null
  $ echo more_multiple_reviewers > foo
  $ hg commit -m 'Bug 3 - More multiple reviewers'
  created new head
  $ hg --config bugzilla.username=author@example.com push > /dev/null

  $ rbmanage add-reviewer $HGPORT1 5 --user reviewer --user rev2
  2 people listed on review request
  $ rbmanage publish $HGPORT1 5

  $ exportbzauth reviewer@example.com password
  $ rbmanage create-review $HGPORT1 5 --body-top 'land it!' --public --ship-it
  created review 3

  $ bugzilla dump-bug 3
  Bug 3:
    attachments:
    - attacher: author@example.com
      content_type: text/x-review-board-request
      data: http://example.com/r/5/
      description: 'MozReview Request: bz://3/mynick'
      flags:
      - id: 5
        name: review
        requestee: reviewer2@example.com
        setter: author@example.com
        status: '?'
      - id: 6
        name: review
        requestee: reviewer@example.com
        setter: author@example.com
        status: '?'
      - id: 7
        name: review
        requestee: null
        setter: reviewer@example.com
        status: +
      id: 3
      summary: 'MozReview Request: bz://3/mynick'
    comments:
    - author: author@example.com
      id: 11
      tags: []
      text: ''
    - author: author@example.com
      id: 12
      tags: []
      text: 'Created attachment 3 [details] [diff] [review]
  
        MozReview Request: bz://3/mynick'
    - author: author@example.com
      id: 13
      tags: []
      text: '/r/6 - Bug 3 - More multiple reviewers
  
  
        Pull down this commit:
  
  
        hg pull review -r fb992de2921c9dd3117becff799b1e41e0dc4827'
    - author: reviewer@example.com
      id: 14
      tags: []
      text: 'http://example.com/r/5/#review3
  
  
        land it!'
    summary: More Multiple Reviewers

I should have a fix soon (I hope).
Assignee: nobody → gps
Blocks: 1021929
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Comment 2

4 years ago
I tacked the fix on to an existing review series that was already in flight. I really wish we didn't map review series to bugs...

https://reviewboard-dev.allizom.org/r/279/
(Assignee)

Comment 4

4 years ago
Will leave review open in case smacleod cares to post review.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1088432
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.