1087647 - ./mach reftest has "Error: Could not find debugger None." in its first few lines of output

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Run "./mach reftest". Look at the first few lines of output.

ACTUAL RESULTS:
The third line of output is:
> Error: Could not find debugger None.

EXPECTED RESULTS:
No such error message; mach shouldn't be trying to find or run a debugger called "None"!



Looks like we're initializing "debugger" to None here:
http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/mach_commands.py?rev=e8559c32028f#217

...but the error message seems to come from here:
http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdebug/mozdebug/mozdebug.py?rev=d29a91fd9c40#105

Not sure where exactly the bug lies.  (Presumably somewhere in between those two parts of the code.)

Comment 1

[(not currently active) Ted Mielczarek]

Dexter: can you take a look at this? It's not fatal, just annoying.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1087647.patch

This patch fixes the issue by making runreftest.py not call |get_debugger_info| if no debugger name was provided.

I've used 2 spaces instead of 4 spaces to conform to local styling. Is this ok?

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1087647.patch

I've updated the commit message by adding the rewiever name.

Comment 4

[Alessio Placitelli [:Dexter]]

The try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fe0f5c8a0a88. It contains some failures, which I think may be unrelated.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c5d603aa12f

In the future, try to be more conscientious about your Try runs. Given that patch only touched the desktop reftest harness, the vast majority of that Try run was wasted cycles that contribute to backlog pain felt by all developers. The link below has some more recommendations to look at.
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c5d603aa12f

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> In the future, try to be more conscientious about your Try runs. Given that
> patch only touched the desktop reftest harness, the vast majority of that
> Try run was wasted cycles that contribute to backlog pain felt by all
> developers. The link below has some more recommendations to look at.
> https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

I'm terribly sorry about that. I will be taking more care about this issue next time.