1087653 - `precompile` is not a recognized element within a Web App Manifest

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

New in 1.4 is the precompile manifest key for apps that use asm.js.

Testing on payments-alt.allizom.org, I get the following validation report:

https://payments-alt.allizom.org/developers/upload/9d162dd3dbdb4250be104980a54eae69

https://developer.mozilla.org/en-US/Apps/Build/Manifest#precompile

The validator should not flag the precompile key in manifests.

Comment 1

[:Harald Kirschner :digitarald]

First partners that we work with will submit apps with asm.js `precompile` beginning of December.

Comment 2

[Mathieu Pillard [:mat]]

We are probably going to want a buchet for this as well.

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/app-validator/pull/41

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/app-validator/commit/2c8b3d4964b162198c4b058df0fdc0438ecdc65e
https://github.com/mozilla/zamboni/commit/2905e6e112f3bfda15c6fe880d2bc68732a09b6e

Comment 5

[Mark Striemer [:mstriemer]]

STR

1. Go to https://marketplace-dev.allizom.org/developers/validator or https://marketplace.allizom.org/developers/validator.
2. Set http://precompile.testmanifest.com/manifest.webapp as the Hosted Manifest URL.
3. Validate.
4. Verify that the warning "`precompile` is not a recognized element within a Web App Manifest" does not occur.