Closed Bug 1087731 Opened 6 years ago Closed 6 years ago

Make JS callers of ios.newChannel call ios.newChannel2 in image/

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1087720
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attached patch js_7_image.patchSplinter Review
Seth, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Since all the channels created in this patch are created in some kind of test-environment, I believe that the arguments provided should be accurate. But please double check. If there are more appropriate arguments to use, please let me know. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#202
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#76
Attachment #8536708 - Flags: review?(seth)
Comment on attachment 8536708 [details] [diff] [review]
js_7_image.patch

Review of attachment 8536708 [details] [diff] [review]:
-----------------------------------------------------------------

OK, based upon the docs you linked to, these values seem correct to me.
Attachment #8536708 - Flags: review?(seth) → review+
https://hg.mozilla.org/mozilla-central/rev/24997b35fe64
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.