1087731 - Make JS callers of ios.newChannel call ios.newChannel2 in image/

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: js_7_image.patch

Seth, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Since all the channels created in this patch are created in some kind of test-environment, I believe that the arguments provided should be accurate. But please double check. If there are more appropriate arguments to use, please let me know. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#202
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#76

Comment 2

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8536708 [details] [diff] [review]
js_7_image.patch

Review of attachment 8536708 [details] [diff] [review]:
-----------------------------------------------------------------

OK, based upon the docs you linked to, these values seem correct to me.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/24997b35fe64

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/24997b35fe64