If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make JS callers of ios.newChannel call ios.newChannel2 in intl/

RESOLVED FIXED in mozilla37

Status

()

Core
DOM: Security
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Blocks: 1087720
(Assignee)

Updated

3 years ago
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8536711 [details] [diff] [review]
js_8_intl.patch

Simon, in Bug 1038756 we started attaching a loadInfo to every channel whenever the channel gets created through NS_NewChannel in nsNetUtil.h. Now we are expanding the loadInfo attachment to also include channels that get created within JS to ultimately end up having a loadInfo on every channel.

Please find a description of all the required arguments to create a channel here [1] or alternatively here [2].

Since all the channels created in this patch are created in some kind of test-environment, I believe that the arguments provided should be accurate. But please double check. If there are more appropriate arguments to use, please let me know. Thanks!

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsNetUtil.h#202
[2] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIIOService.idl#76
Attachment #8536711 - Flags: review?(smontagu)
Comment on attachment 8536711 [details] [diff] [review]
js_8_intl.patch

Review of attachment 8536711 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, AFAICT those are the correct arguments for these tests (I was a bit worried by the big scary warning in nsIContentPolicy.idl "Do not use TYPE_OTHER under any circumstances", but in practice it seems to be used all over the place, and here all we are doing anyway is using the data: URL as a lever to pass strings through nsIConverterInputStream and not actually loading anything).

::: intl/uconv/tests/unit/test_bug317216.js
@@ +90,5 @@
>                                                 bufferLength,
>                                                 0xFFFD);
>  
>    if (!(testConverter instanceof
>          Components.interfaces.nsIUnicharLineInputStream))

Nit: if you've already defined Ci above, you might as well use it here and other places that use Components.interfaces.
Attachment #8536711 - Flags: review?(smontagu) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/698b114bc2ed
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/698b114bc2ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.