1087734 - Use close button ("x") on new tablet tab strip

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Assets and idea via bug 1064415 comment 14.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot, new icon

Anthony, what do you think?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Use new close tab asset on new tablet tab strip

Trimage was run.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8509921 [details] [diff] [review]
Use new close tab asset on new tablet tab strip

Spare Lucas' review queue.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8509919 [details]
Screenshot, new icon

Looks good!

Comment 5

[Martyn Haigh (:mhaigh)]

Comment on attachment 8509921 [details] [diff] [review]
Use new close tab asset on new tablet tab strip

Review of attachment 8509921 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need the mdpi or the xhdpi assets.  As Commonsware mentions here http://stackoverflow.com/a/19196749/264276, the system will downscale from the largest given asset.  You will, however, need to specify an hdpi asset, as neither xhdpi nor xxhdpi existed for API Level 7 and below.  Up to you if you wanna play with that - we're tracking it on bug 959203.  Patch looks good to go regardless.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Martyn Haigh (:mhaigh) from comment #5)
> You don't need the mdpi or the xhdpi assets.  As Commonsware mentions here
> http://stackoverflow.com/a/19196749/264276, the system will downscale from
> the largest given asset.  You will, however, need to specify an hdpi asset,
> as neither xhdpi nor xxhdpi existed for API Level 7 and below.  Up to you if
> you wanna play with that - we're tracking it on bug 959203.  Patch looks
> good to go regardless.

I'm going to let bug 959203 take care of this - just in case we decide we don't want to move forward with this approach or backout, it makes things cleaner.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/4c778609acfc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c778609acfc