1087788 - Status bar icons still overlapping with URL bar when geolocation icon is involved

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: 2014-10-22-16-35-48.png

on 2.1:

STR: open smart collection or maps app that uses geolocation
switch to installed twitter app
pull the utility tray down and up a few times

Comment 1

[Guillaume Marty [:gmarty]]

Simpler STR: on an eng build, open the Geoloc app, click on Start, then Stop and wait a little bit.

Comment 2

[Guillaume Marty [:gmarty]]

Attachment: Github PR

This is a regression introduced by Bug 1078727.
We need to reapply the same CSS classes to the minimised status bar when we clone it without calling _updateIconVisibility().

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8510306 [details] [review]
Github PR

r=me with a quick unit test added (should be straightforward enoug, you can add the class yourself before calling cloneStatusBar then check again).

And I'm glad to know we'll soon be able to cover it with an integration test :)

Comment 4

[Gregor Wagner [:gwagner]]

Bad UX on a main user-facing item.

Comment 5

[Guillaume Marty [:gmarty]]

Landed in master https://github.com/mozilla-b2g/gaia/commit/37200097636520df52ed1208e637ff167f3b9765

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8510306 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Status bar icon prioritisation
[User impact] if declined: Bad UX + regression
[Testing completed]: Unit test covered but manual testing is required
[Risk to taking this patch] (and alternatives if risky): Very low risk as the change is minimal
[String changes made]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/212822ad225230017a6bd405a956cd596695c5f5

Comment 8

[Duane Dixon [:ddixon]]

Issue is verified fixed in Flame 2.2, 2.1 (Full Flash, nightly, 319 MB memory)

Actual Results: Icons in Status Bar do not overlap the URL bar when Geolocation feature is active. 

Device: Flame 2.2
BuildID: 20141029040208
Gaia: 35e87ac4324f0f3abd93dcc70d61c9f37256a0f5
Gecko: 7e3c85754d32
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
BuildID: 20141029001202
Gaia: eb0aab0f13c78c7ac378ad860e865c4b6eaf669f
Gecko: 318019f80a8e
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0