Closed Bug 1087853 Opened 9 years ago Closed 9 years ago

NFC: NfcManager should use message.records to check if NDEF is contained

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S8 (7Nov)

People

(Reporter: allstars.chh, Assigned: tauzen)

References

Details

Attachments

(1 file)

pull-request-1087853.txt
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review 
In the system message 'nfc-manager-tech-discovered' NfcManager should use the 'records' properties to check if NDEF is contained in this system message, it shouldn't check if 'NDEF' is contained in the techList.
Assignee: nobody → kmioduszewski

        Attachment #8512072 -
        Flags: review?(gweng)

    
    

    
  
Comment on attachment 8512072 [details] [review]
pull-request-1087853.txt

r+ with one nit. Thanks.

        Attachment #8512072 -
        Flags: review?(gweng) → review+

    
    

    
  
Thanks for the review! Fixed the nit, and gaia try is green.
Keywords: checkin-needed

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/f17630d89679e159e0af31516a4b7b9d5e938716
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)

          You need to log in
          before you can comment on or make changes to this bug.