NFC: NfcManager should use message.records to check if NDEF is contained

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: allstars.chh, Assigned: tauzen)

Tracking

unspecified
2.1 S8 (7Nov)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In the system message 'nfc-manager-tech-discovered' NfcManager should use the 'records' properties to check if NDEF is contained in this system message, it shouldn't check if 'NDEF' is contained in the techList.
(Assignee)

Updated

4 years ago
Assignee: nobody → kmioduszewski
(Assignee)

Comment 1

4 years ago
Created attachment 8512072 [details] [review]
pull-request-1087853.txt
Attachment #8512072 - Flags: review?(gweng)
Comment on attachment 8512072 [details] [review]
pull-request-1087853.txt

r+ with one nit. Thanks.
Attachment #8512072 - Flags: review?(gweng) → review+
(Assignee)

Comment 3

4 years ago
Thanks for the review! Fixed the nit, and gaia try is green.
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/f17630d89679e159e0af31516a4b7b9d5e938716
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
(Reporter)

Updated

4 years ago
No longer blocks: 1042851
(Reporter)

Updated

4 years ago
Blocks: 1042851
You need to log in before you can comment on or make changes to this bug.