1087917 - jquery scripts not working

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Max]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141011015303

Steps to reproduce:

http://rebetiko.sealabs.net/display2.php is working normally
http://rebetiko.sealabs.net/display3.php keeps freezing


Actual results:

http://rebetiko.sealabs.net/display3.php keeps freezing, while in other browsers like chrome, works as expected.


Expected results:

It should not say "creating playlist" and work as expected, like in other browsers

Comment 1

[Loic]

http://rebetiko.sealabs.net/display3.php doesn't freeze for me with FF33 on Win 7.
Could you test with a clean profile, please.
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 2

[Max]

Yes I tested it with a clean profile and I have the same as you can see here:

http://oi58.tinypic.com/mrdkn.jpg

I am also using FF33 on Win7

Comment 3

[Loic]

Ok, I see the issue, your description wasn't very accurate, I thought it was the entire browser which hung. 

Anyway, I tested in FF34+, the player works so I think it's already fixed in higher versions.
Could you download Beta and confirm on your side, please.
https://www.mozilla.org/en-US/firefox/beta/all/

Comment 4

[Max]

Yes, sorry for my description and grammar.. 

Actually the jquery player works for that page, but for another artist, like in http://rebetiko.sealabs.net/display4.php
we have the same again. THe player's code I think is OK, jQuery which works with chrome

Comment 5

[Loic]

Indeed, it doesn't work for this page. It would be nice to have a minimal reduced testcase (only the player in plain page, without all the artist details).

Comment 6

[Max]

Ok, I have created minimal page http://rebetiko.sealabs.net/display5.php without all the other artist and song details.

Comment 7

[Loic]

STR: http://rebetiko.sealabs.net/display5.php

Regression range:
good=2012-09-11
bad=2012-09-12
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=96287ad60bef&tochange=6e78c3efd115

I think it's an issue about recursion in the JS code, with Ion involved.

Any idea, Alice?

Comment 8

[Alice0775 White]

I have no idea but disabled ion does not help...

Comment 9

[Jan de Mooij [:jandem]]

I can't reproduce this on OS X, tried both a nightly build and Firefox 32.

(In reply to Loic from comment #7)
> I think it's an issue about recursion in the JS code, with Ion involved.

It's possible, recursion limits are platform specific unfortunately..

Comment 10

[Max]

Yes, I also have just tested this in MacOS and seems that works normally with Firefox 32. It is not my area and sorry if I interfere but if the recursion limits are platform specific, shouldn't all browsers in that case have the same problem in the same platform?

Comment 11

[Jan de Mooij [:jandem]]

Sorry for the late response! Is this still an issue with latest release?

If it is, can you also test with the latest Nightly build? http://nightly.mozilla.org/

Comment 12

[Alice0775 White]

(In reply to Jan de Mooij [:jandem] from comment #11)
> Sorry for the late response! Is this still an issue with latest release?
> 
> If it is, can you also test with the latest Nightly build?
> http://nightly.mozilla.org/

I can reproduce this on 
https://hg.mozilla.org/mozilla-central/rev/c1f6345f2803
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150115030228

too much recursion jquery.min.js:2:19707

Comment 13

[Jan de Mooij [:jandem]]

(In reply to Alice0775 White from comment #12)
> I can reproduce this on 
> https://hg.mozilla.org/mozilla-central/rev/c1f6345f2803
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
> ID:20150115030228

So does this only happen on 64-bit? Could you please try this build when it's done:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80711912f6d7
https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-80711912f6d7

When it throws "too much recursion" it should print a list of JS frames to stderr. It'd be great if somebody could attach it (or mail it to me) :)

Comment 14

[Alice0775 White]

I can reproduce with STR of comment#7 on ubuntu14.04 32/64bit both
https://hg.mozilla.org/mozilla-central/rev/93f526d85b47
Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150120030203
https://hg.mozilla.org/mozilla-central/rev/93f526d85b47
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150120030203

Comment 15

[Alice0775 White]

Attachment: log.txt

(In reply to Jan de Mooij [:jandem] from comment #13)
> 
> Could you please try this build when
> it's done:
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=80711912f6d7
> https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> [e-mail]-80711912f6d7
> 
> When it throws "too much recursion" it should print a list of JS frames to
> stderr. It'd be great if somebody could attach it (or mail it to me) :)

Attached.

Comment 16

[Jan de Mooij [:jandem]]

(In reply to Alice0775 White from comment #15)
> Attached.

Thanks. I can also repro this locally. All scripts on the stack are JIT'ed but the stack is just pretty deep: more than 1100 JS frames when we throw. Bug 1108290 might help a bit, but mostly the website should be rewritten to not require so much stack space..

Comment 17

[Max]

I can understand if this is something difficult to solve. But the site is just fetching this amount of rows from and SQL, as result to a simple query, it is impossible to rewrite better this part of code, as always we need to fetch for example 200 rows for a particular query.

Comment 18

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Max,

I was not able to access any of the provided URLs. Can you please provide another URL or a test case so I can test this on my end?

Also, is this still reproducible on your end ? If yes, can you please retest this using latest FF release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E). 

Thanks,
Cosmin.

Comment 19

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Marking this as Resolved: Incomplete due to the lack of response from the reporter.
If anyone can still reproduce it on latest versions, feel free to reopen the issue and provide more information.

Thanks,
Cosmin.