1087968 - Rewrite icc marionette tests with Promise

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Edgar Chen [:edgar]]

We could reuse the head.js introduced in bug 1084233.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 1: Split test_stk_proactive_command.js into localInfo and timerManagement, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 2: Rewrite test_stk_* with Promise, v1

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 3: Rewrite test_icc_* with Promise, v1

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 3: Rewrite test_icc_* with Promise, v2

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part 4: Deferred object is obsoleted since Gecko 30, use new Promise instead, v1

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8551817 [details] [diff] [review]
Part 1: Split test_stk_proactive_command.js into localInfo and timerManagement, v1

Review of attachment 8551817 [details] [diff] [review]:
-----------------------------------------------------------------

Split test_stk_proactive_command.js into two tests, test_stk_local_info.js and test_stk_timer_management.js. And also rewrite them with Promise.
Hi Hsinyi, would you mind reviewing this? Thank you.

Comment 8

[Edgar Chen [:edgar]]

Comment on attachment 8552926 [details] [diff] [review]
Part 4: Deferred object is obsoleted since Gecko 30, use new Promise instead, v1

Review of attachment 8552926 [details] [diff] [review]:
-----------------------------------------------------------------

Deferred in Promise.jsm is obsoleted since Gecko 30 [1], we should use new Promise instead.
Although we don't use Promise.jsm in icc marionette tests, but I would still like to remove faked Deferred and follow the standard way to create a new promise.

Hi Hsinyi, may I have your review? Thank you.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Deferred

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8551817 [details] [diff] [review]
Part 1: Split test_stk_proactive_command.js into localInfo and timerManagement, v1

Review of attachment 8551817 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thought it would be more perfect that |sendEmulatorStkPdu| is added in part 1 instead of part 2 ;)

Comment 10

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #9)
> Comment on attachment 8551817 [details] [diff] [review]
> Part 1: Split test_stk_proactive_command.js into localInfo and
> timerManagement, v1
> 
> Review of attachment 8551817 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good thought it would be more perfect that |sendEmulatorStkPdu| is
> added in part 1 instead of part 2 ;)

Oops!! Will move |sendEmulatorStkPdu| to part 1, thanks for catching this.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8552917 [details] [diff] [review]
Part 3: Rewrite test_icc_* with Promise, v2

Review of attachment 8552917 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 12

[Edgar Chen [:edgar]]

Attachment: Part 1: Split test_stk_proactive_command.js into localInfo and timerManagement, v2, r=hsinyi

Address review comment #9
- Moving |sendEmulatorStkPdu| to part 1

Comment 13

[Edgar Chen [:edgar]]

Attachment: Part 2: Rewrite test_stk_* with Promise, v2, r=hsinyi

Address review comment #9
- Moving |sendEmulatorStkPdu| to part 1

Comment 14

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2112e1026924

Comment 15

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f972d9f7d3a1
https://hg.mozilla.org/integration/b2g-inbound/rev/28ed9a100130
https://hg.mozilla.org/integration/b2g-inbound/rev/3cf44a08328a
https://hg.mozilla.org/integration/b2g-inbound/rev/0e4c49b5337a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f972d9f7d3a1
https://hg.mozilla.org/mozilla-central/rev/28ed9a100130
https://hg.mozilla.org/mozilla-central/rev/3cf44a08328a
https://hg.mozilla.org/mozilla-central/rev/0e4c49b5337a