Closed Bug 1088029 Opened 10 years ago Closed 10 years ago

[OS X] Missing repository information (location and changeset) in report

Categories

(Testing Graveyard :: Mozmill, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-2.0.9+])

Attachments

(2 files)

Since a while we have seen that the repository information is not present in the reports. Somewhat makes us fail here. Maybe it is related to the new structure of the binaries on OS X and this particular issue fall through when I was working on its support.

We need this for Mozmill 2.0.9.
The problematic line is here:
https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L480

So we fail because the version of Mozrunner (5.35) we are using on the hotfix-2.0 branch does not support the new location of the platform.ini and application.ini file.

Given that with mozrunner 6.0 we got a large rewrite I'm not that hesitated to upgrade the package for the hotfix-2.0 branch. We should re-implement the logic in mozmill base.
(In reply to Henrik Skupin (:whimboo) from comment #1)
> Given that with mozrunner 6.0 we got a large rewrite I'm not that hesitated
> to upgrade the package for the hotfix-2.0 branch. We should re-implement the
> logic in mozmill base.

That would even not be helpful given that get_repositoryInfo() has also been completely removed. I assume that was wanted? Andrew, can you have a look at bug 997244 again?

I will replace the code in mozmill by using mozversion directly.
Flags: needinfo?(ahalberstadt)
Yeah, that is handled by mozversion now instead of mozrunner.
Flags: needinfo?(ahalberstadt)
Depends on: 1088060
Keep in mind that this patch depends on the not yet release version 1.0 of mozversion.
Attachment #8510397 - Flags: review?(ahalberstadt)
Attachment #8510397 - Flags: review?(ahalberstadt) → review?(cmanchester)
Comment on attachment 8510397 [details] [diff] [review]
use mozversion to get application and repository information v1

Review of attachment 8510397 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozmill/setup.py
@@ +12,4 @@
>          'ManifestDestiny == 0.5.7',
>          'mozinfo == 0.7',
>          'mozrunner == 5.35',
> +        'mozversion == 1.0'

Maybe keep a trailing comma around? I used to think it was pretty silly, but I suppose it makes patches like these easier to review :)
Attachment #8510397 - Flags: review?(cmanchester) → review+
Blocks: 1056045
For master we need a slightly different patch.
Attachment #8510945 - Flags: review?(cmanchester)
https://github.com/mozilla/mozmill/commit/d0abd2afa830a9bfa9e7c2a4e93e248302c89309 (hotfix-2.0)
Flags: in-testsuite-
Whiteboard: [mozmill-2.0.9+]
Attachment #8510945 - Flags: review?(cmanchester) → review?(ahalberstadt)
Attachment #8510945 - Flags: review?(ahalberstadt) → review+
Thanks Andrew!

https://github.com/mozilla/mozmill/commit/d8527df3d3a4c8272f509b958cf971075a46ef33 (master)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: