1088042 - "JWK export of a symmetric key" test uses a malformed JsonWebKey object

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Guilherme Gonçalves [:ggp]]

It's missing the required kty field. This caused the binding layer to reject the object [1] when importing the key, and |mDataIsJwk| to be used uninitialized later in ImportSymmetricKeyTask::BeforeCrypto.

1- http://dxr.mozilla.org/mozilla-central/source/dom/crypto/WebCryptoTask.cpp#1282

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: Fix JsonWebKey object in test_WebCrypto_JWK

This patch properly initializes mDataIsJwk and fixes the JsonWebKey object. However,
a proper solution to this probably involves propagating the error from the binding
layer instead of swallowing it inside SetKeyData.

Comment 2

[Guilherme Gonçalves [:ggp]]

Attachment: Fix JsonWebKey object in test_WebCrypto_JWK.

This updated version will also abort early when SetKeyData fails in the constructors
for Import*KeyTask.

Since SetKeyData(const CryptoBuffer &) was already setting mEarlyRv implicitly through
SetJwkFromKeyData, I made SetKeyData(JSContext*, JSHandle<JSObject*>) also set mEarlyRv
and the ctors return early when it indicates failure.

Comment 3

[Guilherme Gonçalves [:ggp]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=345d0197ea50

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/299ebc930b9c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/299ebc930b9c