Closed Bug 1088044 Opened 7 years ago Closed 7 years ago

win8 64 talos is posting to the pgo branch

Categories

(Release Engineering :: General, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: armenzg)

Details

Attachments

(2 files, 3 obsolete files)

I had some alerts today about regressions in win8.  This is odd because I validated we were doing better, so I expected improvements.  The key here is we are posting our non-pgo opt builds talos data to the default branch (where we were posting pgo data to).  This means all talos graphs/alerts/data as of yesterday for win8 will be misleading and sort of useless for comparison purposes.

I suspect the reason is how we define non-pgo branches.  If the platform doesn't support pgo (osx), then we post to the branch name (i.e. mozilla-inbound), but if we do support pgo, then we post to branch_name-Non-PGO (i.e. mozilla-inbound-non-pgo).

this tells me we should enable PGO for win8 asap or else when we do switch all our data collected from yesterday -> today will be again deemed useless.
It seems we won't have win64 pgo builds for now (bug 1086703).

I think we should revert until we fix this bug.

jmaher, I think we need to do this:
1) make win8_64 non_pgo post to win8_64 non_pgo
2) enable win8_32 for pgo until bug 1086703 is fixed

The misc.py code to do #1 is rather cumbersome:
* I assume for win64 we set create_pgo_builders = False [1]
* Which then makes us to post to $branch_name rather than $branch_name-Non-PGO [2]

[1] http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l2500
[2] http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l2541
Attached patch configs.non_pgo.diff (obsolete) — Splinter Review
Attachment #8510430 - Flags: review?(catlee)
Attached patch custom.non_pgo.diff (obsolete) — Splinter Review
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Attachment #8510431 - Flags: review?(catlee)
Attached patch differences.diff (obsolete) — Splinter Review
(venv)armenzg-thinkpad buildbot-configs hg:[default!] $ grep "talos\ " ~/moz/patches/differences.diff 
@@ -35350,3 +35350,3 @@ Windows 8 64-bit ash talos chromez Scrip
@@ -35365,3 +35365,3 @@ Windows 8 64-bit ash talos dromaeojs Scr
@@ -35380,3 +35380,3 @@ Windows 8 64-bit ash talos g1 ScriptFact
@@ -35395,3 +35395,3 @@ Windows 8 64-bit ash talos other_nol64 S
@@ -35410,3 +35410,3 @@ Windows 8 64-bit ash talos svgr ScriptFa
@@ -35425,3 +35425,3 @@ Windows 8 64-bit ash talos tp5o ScriptFa
@@ -36091,3 +36091,3 @@ Windows 8 64-bit b2g-inbound talos chrom
@@ -36106,3 +36106,3 @@ Windows 8 64-bit b2g-inbound talos droma
@@ -36121,3 +36121,3 @@ Windows 8 64-bit b2g-inbound talos g1 Sc
@@ -36136,3 +36136,3 @@ Windows 8 64-bit b2g-inbound talos other
@@ -36151,3 +36151,3 @@ Windows 8 64-bit b2g-inbound talos svgr
@@ -36166,3 +36166,3 @@ Windows 8 64-bit b2g-inbound talos tp5o
@@ -37132,3 +37132,3 @@ Windows 8 64-bit cedar talos chromez Scr
@@ -37147,3 +37147,3 @@ Windows 8 64-bit cedar talos dromaeojs S
@@ -37162,3 +37162,3 @@ Windows 8 64-bit cedar talos g1 ScriptFa
@@ -37177,3 +37177,3 @@ Windows 8 64-bit cedar talos other_nol64
@@ -37192,3 +37192,3 @@ Windows 8 64-bit cedar talos svgr Script
@@ -37207,3 +37207,3 @@ Windows 8 64-bit cedar talos tp5o Script
@@ -37873,3 +37873,3 @@ Windows 8 64-bit cypress talos chromez S
@@ -37888,3 +37888,3 @@ Windows 8 64-bit cypress talos dromaeojs
@@ -37903,3 +37903,3 @@ Windows 8 64-bit cypress talos g1 Script
@@ -37918,3 +37918,3 @@ Windows 8 64-bit cypress talos other_nol
@@ -37933,3 +37933,3 @@ Windows 8 64-bit cypress talos svgr Scri
@@ -37948,3 +37948,3 @@ Windows 8 64-bit cypress talos tp5o Scri
@@ -38614,3 +38614,3 @@ Windows 8 64-bit date talos chromez Scri
@@ -38629,3 +38629,3 @@ Windows 8 64-bit date talos dromaeojs Sc
@@ -38644,3 +38644,3 @@ Windows 8 64-bit date talos g1 ScriptFac
@@ -38659,3 +38659,3 @@ Windows 8 64-bit date talos other_nol64
@@ -38674,3 +38674,3 @@ Windows 8 64-bit date talos svgr ScriptF
@@ -38689,3 +38689,3 @@ Windows 8 64-bit date talos tp5o ScriptF
@@ -39355,3 +39355,3 @@ Windows 8 64-bit fig talos chromez Scrip
@@ -39370,3 +39370,3 @@ Windows 8 64-bit fig talos dromaeojs Scr
@@ -39385,3 +39385,3 @@ Windows 8 64-bit fig talos g1 ScriptFact
@@ -39400,3 +39400,3 @@ Windows 8 64-bit fig talos other_nol64 S
@@ -39415,3 +39415,3 @@ Windows 8 64-bit fig talos svgr ScriptFa
@@ -39430,3 +39430,3 @@ Windows 8 64-bit fig talos tp5o ScriptFa
@@ -40096,3 +40096,3 @@ Windows 8 64-bit fx-team talos chromez S
@@ -40111,3 +40111,3 @@ Windows 8 64-bit fx-team talos dromaeojs
@@ -40126,3 +40126,3 @@ Windows 8 64-bit fx-team talos g1 Script
@@ -40141,3 +40141,3 @@ Windows 8 64-bit fx-team talos other_nol
@@ -40156,3 +40156,3 @@ Windows 8 64-bit fx-team talos svgr Scri
@@ -40171,3 +40171,3 @@ Windows 8 64-bit fx-team talos tp5o Scri
@@ -40837,3 +40837,3 @@ Windows 8 64-bit gum talos chromez Scrip
@@ -40852,3 +40852,3 @@ Windows 8 64-bit gum talos dromaeojs Scr
@@ -40867,3 +40867,3 @@ Windows 8 64-bit gum talos g1 ScriptFact
@@ -40882,3 +40882,3 @@ Windows 8 64-bit gum talos other_nol64 S
@@ -40897,3 +40897,3 @@ Windows 8 64-bit gum talos svgr ScriptFa
@@ -40912,3 +40912,3 @@ Windows 8 64-bit gum talos tp5o ScriptFa
@@ -41608,3 +41608,3 @@ Windows 8 64-bit holly talos chromez Scr
@@ -41623,3 +41623,3 @@ Windows 8 64-bit holly talos chromez-e10
@@ -41638,3 +41638,3 @@ Windows 8 64-bit holly talos dromaeojs S
@@ -41653,3 +41653,3 @@ Windows 8 64-bit holly talos dromaeojs-e
@@ -41668,3 +41668,3 @@ Windows 8 64-bit holly talos g1 ScriptFa
@@ -41683,3 +41683,3 @@ Windows 8 64-bit holly talos g1-e10s Scr
@@ -41698,3 +41698,3 @@ Windows 8 64-bit holly talos other-e10s_
@@ -41713,3 +41713,3 @@ Windows 8 64-bit holly talos other_nol64
@@ -41728,3 +41728,3 @@ Windows 8 64-bit holly talos svgr Script
@@ -41743,3 +41743,3 @@ Windows 8 64-bit holly talos svgr-e10s S
@@ -41758,3 +41758,3 @@ Windows 8 64-bit holly talos tp5o Script
@@ -41773,3 +41773,3 @@ Windows 8 64-bit holly talos tp5o-e10s S
@@ -42439,3 +42439,3 @@ Windows 8 64-bit jamun talos chromez Scr
@@ -42454,3 +42454,3 @@ Windows 8 64-bit jamun talos dromaeojs S
@@ -42469,3 +42469,3 @@ Windows 8 64-bit jamun talos g1 ScriptFa
@@ -42484,3 +42484,3 @@ Windows 8 64-bit jamun talos other_nol64
@@ -42499,3 +42499,3 @@ Windows 8 64-bit jamun talos svgr Script
@@ -42514,3 +42514,3 @@ Windows 8 64-bit jamun talos tp5o Script
@@ -43180,3 +43180,3 @@ Windows 8 64-bit maple talos chromez Scr
@@ -43195,3 +43195,3 @@ Windows 8 64-bit maple talos dromaeojs S
@@ -43210,3 +43210,3 @@ Windows 8 64-bit maple talos g1 ScriptFa
@@ -43225,3 +43225,3 @@ Windows 8 64-bit maple talos other_nol64
@@ -43240,3 +43240,3 @@ Windows 8 64-bit maple talos svgr Script
@@ -43255,3 +43255,3 @@ Windows 8 64-bit maple talos tp5o Script
@@ -43921,3 +43921,3 @@ Windows 8 64-bit mozilla-central talos c
@@ -43936,3 +43936,3 @@ Windows 8 64-bit mozilla-central talos d
@@ -43951,3 +43951,3 @@ Windows 8 64-bit mozilla-central talos g
@@ -43966,3 +43966,3 @@ Windows 8 64-bit mozilla-central talos o
@@ -43981,3 +43981,3 @@ Windows 8 64-bit mozilla-central talos s
@@ -43996,3 +43996,3 @@ Windows 8 64-bit mozilla-central talos t
@@ -44662,3 +44662,3 @@ Windows 8 64-bit mozilla-inbound talos c
@@ -44677,3 +44677,3 @@ Windows 8 64-bit mozilla-inbound talos d
@@ -44692,3 +44692,3 @@ Windows 8 64-bit mozilla-inbound talos g
@@ -44707,3 +44707,3 @@ Windows 8 64-bit mozilla-inbound talos o
@@ -44722,3 +44722,3 @@ Windows 8 64-bit mozilla-inbound talos s
@@ -44737,3 +44737,3 @@ Windows 8 64-bit mozilla-inbound talos t
@@ -46054,3 +46054,3 @@ Windows 8 64-bit try talos chromez Scrip
@@ -46069,3 +46069,3 @@ Windows 8 64-bit try talos dromaeojs Scr
@@ -46084,3 +46084,3 @@ Windows 8 64-bit try talos g1 ScriptFact
@@ -46099,3 +46099,3 @@ Windows 8 64-bit try talos other_nol64 S
@@ -46114,3 +46114,3 @@ Windows 8 64-bit try talos svgr ScriptFa
@@ -46129,3 +46129,3 @@ Windows 8 64-bit try talos tp5o ScriptFa
Attachment #8510432 - Flags: feedback?(catlee)
Attached patch win64_pgo.diffSplinter Review
Attachment #8510430 - Attachment is obsolete: true
Attachment #8510431 - Attachment is obsolete: true
Attachment #8510432 - Attachment is obsolete: true
Attachment #8510430 - Flags: review?(catlee)
Attachment #8510431 - Flags: review?(catlee)
Attachment #8510432 - Flags: feedback?(catlee)
Attachment #8510568 - Flags: review?(catlee)
Attached file differences.txt
Adding the PGO builders will make each job post to the right tree without having to hack misc.py even further.
Comment on attachment 8510568 [details] [diff] [review]
win64_pgo.diff

Review of attachment 8510568 [details] [diff] [review]:
-----------------------------------------------------------------

fingers crossed that it's this simple!
Attachment #8510568 - Flags: review?(catlee) → review+
Comment on attachment 8510568 [details] [diff] [review]
win64_pgo.diff

https://hg.mozilla.org/build/buildbot-configs/rev/ee73b349cb45

I hope so too!
I will ask for a reconfiguration in the morning. I would want to be around.
Attachment #8510568 - Flags: checked-in+
In production with reconfig on 2014-10-24 03:01 PT
I see $branch-Non-PGO posting for opt jobs [1]
I see $branch posting for PGO jobs [2]

Resolved fixed?

[1]
https://tbpl.mozilla.org/php/getParsedLog.php?id=50980459&tree=Mozilla-Inbound&full=1
'c:/mozilla-build/python27/python' '-u' 'scripts/scripts/talos_script.py' '--suite' 'chromez' '--add-option' '--webServer,localhost' '--branch-name' 'Mozilla-Inbound-Non-PGO' '--system-bits' '64' '--cfg' 'talos/windows_config.py' '--download-symbols' 'ondemand' '--use-talos-json' '--blob-upload-branch' 'Mozilla-Inbound-Non-PGO'

[2]
https://tbpl.mozilla.org/php/getParsedLog.php?id=50983422&tree=Mozilla-Inbound&full=1
'c:/mozilla-build/python27/python' '-u' 'scripts/scripts/talos_script.py' '--suite' 'chromez' '--add-option' '--webServer,localhost' '--branch-name' 'Mozilla-Inbound' '--system-bits' '64' '--cfg' 'talos/windows_config.py' '--download-symbols' 'ondemand' '--use-talos-json' '--blob-upload-branch' 'Mozilla-Inbound'
verified with what is live in production on inbound for pgo and non pgo!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.