1088128 - Add support for getCurrentPosition in Geoloc dev app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Dave Huseby [:huseby]]

Currently, the Geoloc dev app only knows how to use the watchPosition functionality of the geolocation API.  As part of the adjustable location accuracy project, I needed a way to also test the getCurrentPosition part of the API.  This patch adds a new button for calling getCurrentPosition to fire off a single shot GPS position query.

Comment 1

[Dave Huseby [:huseby]]

Attachment: github pull request for geoloc dev app change.

I'm not sure who should review this.  I didn't want to bug Vivien, so you get it Jan :)

Comment 2

[Jan Keromnes [:janx]]

Comment on attachment 8510408 [details] [review]
github pull request for geoloc dev app change.

(forwarding to original author)

Comment 3

[Dave Huseby [:huseby]]

I updated the patch.  It no longer includes changes to the other locales.  Blame google translate :)  And thanks for moving the review.

Comment 4

[:gerard-majax]

I'm glad to see that this app is proven to be useful :)

Comment 5

[:gerard-majax]

Comment on attachment 8510408 [details] [review]
github pull request for geoloc dev app change.

See comments on Github: I'm fine with the change, but please factorize a bit between startGeoloc and getGeoloc. I know my code is not perfect, but I feel it's easy to avoid worse here.

Comment 6

[Dave Huseby [:huseby]]

I updated the patch to include the feedback.

Comment 7

[:gerard-majax]

Looks good to me, thanks, that was one of my early contribution to B2G :) !