Closed
Bug 1088179
Opened 10 years ago
Closed 10 years ago
Convert touch caret code to using :-moz-native-anonymous so that it doesn't expose styles for magic attribute names to content
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
We should convert touch caret code to using :-moz-native-anonymous so that it doesn't expose styles for magic attribute names to content, i.e., reland patch 6 of bug 1082899 after fixing the tests.
Assignee | ||
Comment 1•10 years ago
|
||
My mistake was relatively silly; there were 3 elements with 3 different class attributes, so not everything matched .moz-touchcaret. But the existing class attributes were sufficient so I don't need class attribute doubling anymore either. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ee6455b29195 https://tbpl.mozilla.org/?tree=Try&rev=ee6455b29195
Assignee | ||
Comment 2•10 years ago
|
||
I tested locally on a Flame that using this without the ua.css changes breaks the touch caret (it doesn't appear), but with the ua.css changes the touch caret appears again. This was formerly bug 1082899 patch 6.
Attachment #8510508 -
Flags: review?(birtles)
Updated•10 years ago
|
Attachment #8510508 -
Flags: review?(birtles) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/efee5ba65af4
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/efee5ba65af4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•