1088225 - android mozillafilelogger.js needs to remove try/catch around const declarations

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I believe we can simplify that file quite a bit

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: remove try/catch around const declarations (1.0)

there is a bug somewhere which :efaust is working on which requires these changes.  I have tested them with his builds and default builds on a local device successfully.  I ended up removing a lot of extra stuff, in general we are not doing special powers for talos, so I removed a lot of that code.  Also ipc mode was over engineering.

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8510523 [details] [diff] [review]
remove try/catch around const declarations (1.0)

Review of attachment 8510523 [details] [diff] [review]:
-----------------------------------------------------------------

This all makes sense except for the fact that it looks like you're keeping a dead variable "useSpecialPowers" around. r+ with that either addressed or explained.

::: talos/scripts/MozillaFileLogger.js
@@ +2,5 @@
>   * MozFileLogger, a log listener that can write to a local file.
>   */
>  
>  // Detect if we are on older branches that don't have specialpowers enabled talos available
> +var useSpecialPowers = false;

Does this still need to be defined at all?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

so we use it in the quit.js code;  I didn't want to start modifying everything, but if you would prefer, I could make a pass through and remove ipcmode and usespecialpowers from all code.

Comment 4

[William Lachance (:wlach)]

(In reply to Joel Maher (:jmaher) from comment #3)
> so we use it in the quit.js code;  I didn't want to start modifying
> everything, but if you would prefer, I could make a pass through and remove
> ipcmode and usespecialpowers from all code.

Up to you. If it's used elsewhere that's a good enough reason to leave it in. Maybe add a comment that it's still needed by quit.js.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I filed bug 1088252 as a good first bug to do the cleanup, I will add a comment and commit.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/9dfad0333c76