1088230 - Add backwards compatible attribute to LoopServer registration payload

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Paul Kerr [:pkerr]]

Add the simplePushURL attribute to the registration payload along with the simplePushURLs attribute used by the new rooms server API. Assign simplePushURL the pushURL that is assigned to the calls client code.

Comment 1

[Paul Kerr [:pkerr]]

Attachment: add backwards compatible registration payload to new rooms registration

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8510528 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Review of attachment 8510528 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/MozLoopService.jsm
@@ +518,5 @@
>    registerWithLoopServer: function(sessionType, pushUrls, retry = true) {
> +    // create a registration payload with a backwards compatible attribute (simplePushURL)
> +    // that will register only the calls notification.
> +    let msg = { simplePushURL: pushUrls.calls,
> +                simplePushURLs: pushUrls};

Please following the coding style with { and } ending and starting a new line respectively:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#JavaScript_objects

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8510528 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Looks good, r=Standard with the change Matt suggested.

Comment 4

[Paul Kerr [:pkerr]]

Attachment: add backwards compatible registration payload to new rooms registration

incorporate review comment

Comment 5

[Paul Kerr [:pkerr]]

Carrying forward r+ Standard8.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/fa426ab14a9c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa426ab14a9c

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/659774666e93

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8510624 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only

Comment 10

[Mark Banner (:standard8)]

This was a temporary change and has since been removed. Nothing to do on the testsuite side now.