Add backwards compatible attribute to LoopServer registration payload

RESOLVED FIXED in Firefox 35

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: pkerr, Assigned: pkerr)

Tracking

unspecified
mozilla36
Points:
1
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

(Whiteboard: [rooms])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Add the simplePushURL attribute to the registration payload along with the simplePushURLs attribute used by the new rooms server API. Assign simplePushURL the pushURL that is assigned to the calls client code.
Assignee

Updated

5 years ago
Status: NEW → ASSIGNED
Assignee

Updated

5 years ago
Attachment #8510528 - Flags: review?(standard8)
Comment on attachment 8510528 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Review of attachment 8510528 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/MozLoopService.jsm
@@ +518,5 @@
>    registerWithLoopServer: function(sessionType, pushUrls, retry = true) {
> +    // create a registration payload with a backwards compatible attribute (simplePushURL)
> +    // that will register only the calls notification.
> +    let msg = { simplePushURL: pushUrls.calls,
> +                simplePushURLs: pushUrls};

Please following the coding style with { and } ending and starting a new line respectively:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#JavaScript_objects
Comment on attachment 8510528 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Looks good, r=Standard with the change Matt suggested.
Attachment #8510528 - Flags: review?(standard8) → review+
Assignee

Updated

5 years ago
Attachment #8510528 - Attachment is obsolete: true
Assignee

Comment 5

5 years ago
Carrying forward r+ Standard8.
Assignee

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/fa426ab14a9c
Iteration: --- → 36.1
Keywords: checkin-needed
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/fa426ab14a9c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Flags: in-testsuite?
Comment on attachment 8510624 [details] [diff] [review]
add backwards compatible registration payload to new rooms registration

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8510624 - Flags: review+
Attachment #8510624 - Flags: approval-mozilla-aurora?
Attachment #8510624 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This was a temporary change and has since been removed. Nothing to do on the testsuite side now.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.