1088266 - "Share this link" text is not centred in Loop door hanger

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: screenshot of "Share this link" text in Loop doorhanger

1. In Firefox, click Loop's talk icon in the toolbar.

Expected results:
The "Share this link to invite someone to talk:" text is centred. 

Actual results:
Notice the "Share this link to invite someone to talk:" text is not centred (35px on the left, 46px on the right).

I *think* this is a regression - could have been introduced by the addition of the Beta ribbon.

Comment 1

[Mark Banner (:standard8)]

According to the specs, its meant to be left aligned:

https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#precall-firstrun

Therefore, I think this is WFM, as its just left-aligned against the beta ribbon.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Ah, okay that makes sense. From what I've seen in the wild (thinking mainly of GitHub ribbons right now), ribbons typically overlay over a page or island and elements below just pretend the ribbon doesn't exist.

I assume when the Beta ribbon goes away, the text becomes left aligned again. I have an old screenshot from Oct 7 that shows the text to be left aligned. https://www.dropbox.com/s/3100rrch88g0wgn/Screenshot%202014-10-07%2014.02.14.png?dl=0

Closing… feel free to reopen if you wish. Thanks!