Closed Bug 1088268 Opened 5 years ago Closed 5 years ago

Use a switch statement in DOMGCSliceCallback

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file, 1 obsolete file)

This function is kind of a mess.  At a minimum, there should just be one switch statement that cases over aProgress.
Assignee: nobody → continuation
I just did some light local testing, but this shouldn't change any behavior. Unfortunately the diff is likely to be a bit crummy...
Attachment #8543092 - Flags: review?(bugs)
Summary: Clean up DOMGCSliceCallback → Use a switch statement in DOMGCSliceCallback
Fixed some indentation.
Attachment #8543092 - Attachment is obsolete: true
Attachment #8543092 - Flags: review?(bugs)
Attachment #8543096 - Flags: review?(bugs)
Comment on attachment 8543096 [details] [diff] [review]
Use a switch statement in DOMGCSliceCallback.

I guess -w patch might have been smaller.
Attachment #8543096 - Flags: review?(bugs) → review+
In hindsight, I could have split it into one patch for each case and it would have been a little easier to follow.  Oh well.
https://hg.mozilla.org/mozilla-central/rev/d7405ceb19a2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.