Closed
Bug 1088268
Opened 10 years ago
Closed 9 years ago
Use a switch statement in DOMGCSliceCallback
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file, 1 obsolete file)
6.39 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This function is kind of a mess. At a minimum, there should just be one switch statement that cases over aProgress.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 1•9 years ago
|
||
I just did some light local testing, but this shouldn't change any behavior. Unfortunately the diff is likely to be a bit crummy...
Attachment #8543092 -
Flags: review?(bugs)
Assignee | ||
Updated•9 years ago
|
Summary: Clean up DOMGCSliceCallback → Use a switch statement in DOMGCSliceCallback
Assignee | ||
Comment 2•9 years ago
|
||
Fixed some indentation.
Attachment #8543092 -
Attachment is obsolete: true
Attachment #8543092 -
Flags: review?(bugs)
Attachment #8543096 -
Flags: review?(bugs)
Assignee | ||
Comment 3•9 years ago
|
||
try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cd1f9777841e
Comment 4•9 years ago
|
||
Comment on attachment 8543096 [details] [diff] [review] Use a switch statement in DOMGCSliceCallback. I guess -w patch might have been smaller.
Attachment #8543096 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•9 years ago
|
||
In hindsight, I could have split it into one patch for each case and it would have been a little easier to follow. Oh well.
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7405ceb19a2
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d7405ceb19a2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•