1088274 - Exiting fullscreen mode causes artifact on the right window border

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.jpg

1. Go to https://www.youtube.com/watch?v=WwSMAhBgOIw&hd=1
2. Enter fullscreen mode
3. Exit fullscreen mode
4. Enjoy artifact on the right window border

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

The problem happens on not only youtube site but also about;home page

Steps to Reproduce:
1. Start Nightly with default toolbar setting(hide title bar etc..)
2. Maximized
3. Enter Full Screen
4. Exit Full Screen

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79232598a90
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141018140412
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53244356f497
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141018174412
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b79232598a90&tochange=53244356f497

Regressed by:
53244356f497	Harsh Vardhan ? Bug 1026865 - Fullscreen Maximize Fixed in nsWindow.cpp. r=bbondy

Comment 4

[enverest]

My Windows taskbar located at left side. I have artifact at bottom too.
https://pp.vk.me/c622919/v622919541/8ac5/BtE_S9CoTNo.jpg

Comment 6

[Alice0775 White]

:royalharsh95

It is time to backed out the offending patch.

Comment 7

[Alice0775 White]

Attachment: bug.png

And Right edge of the browser is cut off if taskbar on the left.
So window control buttons, hamburger menu button are missing.

Str
1. Taskbar placed on the left side
2. Hide Titlebar
3. Maximized
4.  Enter Full screen
5. Exit Fullscreen

Comment 8

[Brian R. Bondy [:bbondy]]

I'll back out the offending bug and re-open it. I'll leave this open as well and we'll eventually re-land both at the same time.

Comment 9

[Benjamin Kerensa [:bkerensa]]

Tracking this but Brian can you update this to resolved when you confirm after backout.

Comment 10

[Brian R. Bondy [:bbondy]]

Yep. The blocking bug was the one that needed a backout because of this.   It was backed out yesterday, although it hasn't been merged to m-c yet See bug 1026865.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Backout fixed the problem in latest Nightly, so I'm marking this as FIXED looking on Benjamin Kerensa [:bkerensa] comment.