1088283 - Adding URLs to PageMod's include list does on affect open tabs

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[willmarquardt]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141020184313

Steps to reproduce:

Created a PageMod with attachTo: 'existing'
Added currently open tab's URL to PageMod with `pageMod.include.add(url);`


Actual results:

Nothing until I reloaded the page


Expected results:

The PageMod should instantly be applied to the currently open page.

I understand that I can use tab.attach for the above functionality, but the repercussions in terms of dealing with different constructor options and worker lifecycles makes it a headache.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I'm afraid include was not intended to be modified after it's attached to the page mod. Although it is a API design flaw we do intend on removing add / remove from include in a future.

As of use case where one would want to apply existing page mod to a different document, that is doable by creation of a new page mod that has new include but shares other page mod options.