1088314 - Use a "Settings" cog/gear icon that is consistent with Firefox's icon

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Similar to bug 1088313, but this is a bug on the Loop side of things.

––

1. Open Loop's call door-hanger pane from Loop's talk icon in Firefox toolbar.
2. Open `about:home` in Firefox.
3. Open Preferences from hamburger icon in Firefox toolbar.

Expected results:
Loop's Settings icon is the same icon used for the Preferences icon in `about:home` and/or the Preference's door–hanger menu. (IMO should choose one until bug 1088313 is fixed.)

Actual results:
Loop's Settings icon is slightly different from the cog/gear icons used elsewhere in Firefox.

Comment 1

[:shell escalante]

Michael, was this intentional?  :) Darrin said it's your call.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Attachment: screenshot of Firefox preference icons

Comment 3

[Romain Testard [:RT]]

Sevaan, is this addressed with visual refresh?

Comment 4

[Sevaan Franks [:sevaan]]

It's the same gear icon as on about:newtab, but it's different to the other gear icons in Firefox.

I did a quick scan and found 4 different kinds of icons: http://i.sevaan.com/image/242Q3e2D0d0b

Stephen, should we have one icon for all these? If so, which?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Sevaan Franks [:sevaan] from comment #4)
> It's the same gear icon as on about:newtab, but it's different to the other
> gear icons in Firefox.
> 
> I did a quick scan and found 4 different kinds of icons:
> http://i.sevaan.com/image/242Q3e2D0d0b

I see you filed bug 1189857 - I filed for most of these last year.

I filed for the icon on `about:home` + the Preferences drop-down: bug 1088313.

I didn't file for the `about:newtab` one (which seems to be same as the one used for Hello) nor the `about:addons` one (which is one I didn't file for).

> Stephen, should we have one icon for all these? If so, which?

I also filed bug 1088317, bug 1088320, bug 1088322 for other inconsistent icons elsewhere in Firefox.

Comment 6

[Tim Nguyen :ntim]

(In reply to Sevaan Franks [:sevaan] from comment #4)
> It's the same gear icon as on about:newtab, but it's different to the other
> gear icons in Firefox.
> 
> I did a quick scan and found 4 different kinds of icons:
> http://i.sevaan.com/image/242Q3e2D0d0b
FYI, the last one is the most used one in Firefox Desktop.
It's used in the toolbar sprite (on Windows and Linux), the share panel, the add-on manager, and in the developer tools.

The first one is used in Firefox Hello, about:newtab, and in Windows and Linux menu-panel sprites. Firefox OS uses a modified version of this one.

The second one is about:home exclusive.

The third one is an OSX specific icon.

Comment 7

[Romain Testard [:RT]]

Thanks guys.

Sevaan/Vicky - does it mean we need to change to the 4th on http://i.sevaan.com/image/242Q3e2D0d0b?

Comment 8

[Victoria Gerchinhoren [:vicky]]

I have asked Stephen for the common assets, icons, color palette, styleguides in general, and the answer is that there's no formal repository or style guide for now. So, as agreed with RT, Sevaan and Stephen, we'll later on introduce the good assets once they are all gathered, as well as other visual language alignment issues.

This is for 2 main reasons, 
1. we are already implementing the UI and short on time for next release.
2. But most important, no mater which icons we use, they need to feel consistent within the product UI, we cannot align 1 and leave another different. We should apply the change once we have a whole set to be replaced.

Thanks!

Comment 9

[Sevaan Franks [:sevaan]]

(In reply to Romain Testard [:RT] from comment #7)
> Thanks guys.
> 
> Sevaan/Vicky - does it mean we need to change to the 4th on
> http://i.sevaan.com/image/242Q3e2D0d0b?

Unless a standardized icon is settled on, we can probably just use what we've got in the meantime for the visual refresh.

Comment 10

[Michael Maslaney [:mmaslaney] ([e-mail])]

We have icon unification work in progress. Keep the one you have for now.

Comment 11

[Mark Banner (:standard8)]

Ok, I'm going to close this as works for me for now, and we'll either re-open when the icons come or deal with them in a new bug.