Closed Bug 1088391 Opened 10 years ago Closed 10 years ago

[Window Management] When called while in an app that can be rotated to landscape view, the incoming call screen can be rotated to landscape

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0 unaffected, b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
2.1 S8 (7Nov)
blocking-b2g 2.1+
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: ckreinbring, Assigned: alive, NeedInfo)

References

Details

(Keywords: regression, Whiteboard: [2.1-bug-bash] )

Attachments

(3 files)

Description:
If the user is called while they are in an app that can be rotated to landscape view (eg browser, gallery or video), the incoming call screen that appears can be rotated to the landscape view.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141023001201
2) Launch an app that can be shown in the landscape view (browser, gallery, etc)
3) From another phone, call the device.
4) When the incoming call screen appears, rotate the device to landscape view.
  
Actual:
The incoming call screen changes to the landscape view.
  
Expected: 
The incoming call screen remains in the portrait view.
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20141023001201
Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko: 09fb60a37850
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Platform Version: 34.0
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 100%
See attached: screenshot and logcat logs
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA-Wanted for branch checks
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: qawanted
The bug repros on Flame 2.2 and Flame 2.1 on both nightly (full flash) and engineering (shallow flash).
Actual result: When being called, the incoming call screen will change to landscape view if the user was in an app that can be shown in landscape view.

Flame 2.2
BuildID: 20141024070214
Gaia: 29ed78a26d62b58f663437a45f273d57b9781d79
Gecko: d6abb9bf43be
Platform Version: 36.0a1
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Nightly
BuildID: 20141024040202
Gaia: d893a9b971a0f3ee48e5a57dca516837d92cf52b
Gecko: a5ee2769eb27
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1
BuildID: 20141024064808
Gaia: 07cd1562b90960a343104a67b184cf9e01bee8a0
Gecko: 4feccadc6146
Platform Version: 34.0
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Nightly
BuildID: 20141023001201
Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko: 09fb60a37850
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Platform Version: 34.0
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 2.0 on both nightly (full flash) and engineering (shallow flash).
Actual result: The incoming call screen remains in the portrait orientation even if the user was in an app that could be seen in landscape view.

Flame 2.0
BuildID: 20141024064809
Gaia: 1a89b5317dbc31da9c604d677a4a5a3e34122a17
Gecko: cfa7cdcb728b
Platform Version: 32.0
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Nightly
BuildID: 20141024000201
Gaia: 86d83f4b4111ca45ebc92ca779348cc966f43cff
Gecko: f8432250efb7
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Platform Version: 32.0
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawantedregression
ni to Dialer owner - is this intended design?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell) → needinfo?(echang)
Whiteboard: [2.1-FC-bug-bash] → [2.1-bug-bash]
[Blocking Requested - why for this release]: Dialer should be locked to portrait mode, regression
blocking-b2g: --- → 2.1?
Flags: needinfo?(echang)
triage: identifiable regression
blocking-b2g: 2.1? → 2.1+
Assignee: nobody → alive
Regression from bug 1071775
Depends on: 1071775
We should only set orientation on callscreen window opening.
Attachment #8512574 - Flags: review?(etienne)
https://github.com/mozilla-b2g/gaia/commit/f74da0ff96f5e6e37be12169b6ca41ab6718e668
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8512574 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25572

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 1071775 regression
[User impact] if declined:
The user will see the incoming call in landscape mode.
[Testing completed]:
Yes
[Risk to taking this patch] (and alternatives if risky):
No
[String changes made]:
No
Attachment #8512574 - Flags: approval-gaia-v2.1?
Attachment #8512574 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Issue is verified fixed in Flame 2.1, 2.2 (Full Flash, nightly).  

Actual Results: Incoming Call screen appears in portrait orientation. 

Device: Flame 2.1
BuildID: 20141031001201
Gaia: f89c7b12c36572262c9ea76058694a139b1a8634
Gecko: 50d48f8a04c7
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2
BuildID: 20141031061804
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 6bd2071b373f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: