1088462 - Very few Statusbar icons display when opening smart collection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot]

Build Information
Gaia-Rev        1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/09fb60a37850
Build-ID        20141023001201
Version         34.0
Device-Name     flame
Base image:     188


Description
When opening e.me, only a few icons display. Oddly, it only seems to happen after opening several browser windows.

Steps to Reproduce
1.) Open the browser, navigate to cnn.com
2.) Long press on a link, and open it in a new tab
3.) From here, long press on a link and open it in a new tab
4.) Press the home button
5.) Immediately open a smart collection


Expected Results
Statusbar icons should fill up the statusbar.


Actual Results
Only a couple icons show up in the statusbar, see screenshot.


Reproduction Frequency: 100%

Comment 1

[Gregor Wagner [:gwagner]]

Broken feature.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, can you take a look here?

Comment 3

[Guillaume Marty [:gmarty]]

This is due to Bug 1087710.

But there is another problem: the maximised status bar should be displayed on smart collections. Currently we show the minimised one, even though there is no rocket bar here.

The CSS code is complex and I know from experience that changing it may have side effects, so redirecting to Kevin. Can we make sure the maximised status bar is always shown on smart collections?

Comment 4

[Kevin Grandon :kgrandon]

I think we can also adjust the minimized statusbar width on activityopened. I'll take this one.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Update minimized statusbar width for activityopened.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8512129 [details] [review]
Github pull request

Guillaume - would you mind giving this a review?

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8512129 [details] [review]
Github pull request

Thanks Kevin, your patch fixes the issue.
However I can only give f+ as I'm not a peer/owner so redirecting r? to Etienne.

Comment 8

[Kevin Grandon :kgrandon]

(In reply to Guillaume Marty [:gmarty] from comment #7)
> Thanks Kevin, your patch fixes the issue.
> However I can only give f+ as I'm not a peer/owner so redirecting r? to
> Etienne.

Sure, though based on what we discussed on the mailing list recently, this is one of those cases where since you've done some work here, you should be able to review for a system peer. IMHO it saves everyone time in the long run, but no harm in re-directing to a peer. Thanks for taking a look.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8512129 [details] [review]
Github pull request

(In reply to Kevin Grandon :kgrandon from comment #8)
> (In reply to Guillaume Marty [:gmarty] from comment #7)
> > Thanks Kevin, your patch fixes the issue.
> > However I can only give f+ as I'm not a peer/owner so redirecting r? to
> > Etienne.
> 
> Sure, though based on what we discussed on the mailing list recently, this
> is one of those cases where since you've done some work here, you should be
> able to review for a system peer. IMHO it saves everyone time in the long
> run, but no harm in re-directing to a peer. Thanks for taking a look.

+1, when a system peer sends/redirects you a review you can totally grant the review.
That's how we make new peers ;)

Comment 10

[Kevin Grandon :kgrandon]

Thanks for the review.

In master: https://github.com/mozilla-b2g/gaia/commit/13b0ac34a06237a544615c72ec208572be83c821

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8512129 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): v2.1 feature implementation.
[User impact] if declined: Less than ideal experience when opening smart collections as icons in the statusbar will disappear.
[Testing completed]: Manual and a simple unit test.
[Risk to taking this patch] (and alternatives if risky): Low risk, basically a one-liner with a test.
[String changes made]: None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/3701d5cfc19085598e321607fe3c210ffaf1ce0e

Comment 13

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Actual Results: Expected amount of icons appear in status bar

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031001201
Gaia: f89c7b12c36572262c9ea76058694a139b1a8634
Gecko: 50d48f8a04c7
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031061804
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 6bd2071b373f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0